Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCE PD CSI Migration Docs #13044

Closed
wants to merge 1 commit into from
Closed

GCE PD CSI Migration Docs #13044

wants to merge 1 commit into from

Conversation

davidz627
Copy link
Contributor

Docs for CSI Migration Alpha for GCE PD.

Parent feature doc: #12935

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 8, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: zhangxiaoyu-zidif

If they are not already assigned, you can assign the PR to them by writing /assign @zhangxiaoyu-zidif in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from msau42 and thockin March 8, 2019 23:13
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. language/en Issues or PRs related to English language labels Mar 8, 2019
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit b65abfc

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5c82f7177b79f4000956be02

msau42
msau42 reviewed Mar 11, 2019
View reviewed changes
content/en/docs/concepts/storage/volumes.md
from the existing in-tree plugin to the `pd.csi.storage.gke.io` Container
Storage Interface (CSI) Driver. In order to use this feature, the [GCE PD CSI
Driver](https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver)
must be installed on the cluster and the `CSIMigration` and `CSIMigrationGCE`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also update feature-gates.md

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nevermind just saw this in the parent pr

@davidz627
Copy link
Contributor Author

This is ready for Docs review

@ddebroy
Copy link
Member

ddebroy commented Mar 13, 2019

Consolidated under #12935. This PR may be closed.

@jimangel jimangel force-pushed the dev-1.14 branch 2 times, most recently from 2534806 to ead0a28 Compare March 14, 2019 03:47
@davidz627 davidz627 closed this Mar 14, 2019
@davidz627
Copy link
Contributor Author

thanks @ddebroy!

@davidz627 davidz627 deleted the feature/gceMigration branch March 14, 2019 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 msau42 left review comments

@thockin thockin Awaiting requested review from thockin

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@davidz627 @k8s-ci-robot @k8sio-netlify-preview-bot @ddebroy @msau42