Deployment documentation incorrectly describes how ReplicaSets are named #12712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I went ahead and corrected the incorrect description, as well as some incorrect examples
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
size/S
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit 2b276b3 https://deploy-preview-12712--kubernetes-io-master-staging.netlify.com |
|
This is a good update to the documentation. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zacharysarah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
2 tasks
kwiesmueller
pushed a commit
to kwiesmueller/website
that referenced
this pull request
Feb 28, 2019
…med (kubernetes#12712) I went ahead and corrected the incorrect description, as well as some incorrect examples
krmayankk
pushed a commit
to krmayankk/kubernetes.github.io
that referenced
this pull request
Mar 11, 2019
…med (kubernetes#12712) I went ahead and corrected the incorrect description, as well as some incorrect examples
yagonobre
pushed a commit
to yagonobre/website
that referenced
this pull request
Mar 14, 2019
…med (kubernetes#12712) I went ahead and corrected the incorrect description, as well as some incorrect examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went ahead and corrected the incorrect description, as well as some incorrect examples
cc: @darkmane @zacharysarah