Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment documentation incorrectly describes how ReplicaSets are named. #11763

Closed
1 of 2 tasks
darkmane opened this issue Dec 14, 2018 · 10 comments
Closed
1 of 2 tasks

Comments

@darkmane
Copy link

This is a...

  • Feature Request
  • Bug Report

Problem:
Deployment documentation incorrectly describes how ReplicaSets are named.

ReplicaSets created by Deployments are no longer named [Deployment Name]-[Pod-template-hash]

Proposed Solution:
Correct how names are generated. I will try and comment with the process once I find it in source code.

Page to Update:
https://kubernetes.io/docs/concepts/workloads/controllers/deployment/

1.9+

@darkmane
Copy link
Author

The pod-template-hash is used as a seed to randomly generate a string, to prevent collisions. I recommend removing the explanation

https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/deployment/sync.go#L183

@zacharysarah
Copy link
Contributor

@juandiegopalomino This may make sense as a follow-up to #12409--what do you think?

@juandiegopalomino
Copy link
Contributor

@zacharysarah alrighty. It seems like a 1-2 sentence fix (or am I missing something), correct?

@zacharysarah
Copy link
Contributor

@juandiegopalomino It looks pretty straightforward, just removing deprecated content. I recommend tagging @darkmane for review on the PR.

@juandiegopalomino
Copy link
Contributor

cool, on it

@DanyC97
Copy link
Contributor

DanyC97 commented Feb 26, 2019

@juandiegopalomino you still on it ? if not let me know and i might have spare cycle to help

@juandiegopalomino
Copy link
Contributor

#12712

@juandiegopalomino
Copy link
Contributor

@DanyC97 ^

@DanyC97
Copy link
Contributor

DanyC97 commented Feb 27, 2019

cool, thank you @juandiegopalomino . in which case i guess current issue can be closed ?

@juandiegopalomino
Copy link
Contributor

I believe so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants