-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deployment documentation incorrectly describes how ReplicaSets are named. #11763
Comments
The pod-template-hash is used as a seed to randomly generate a string, to prevent collisions. I recommend removing the explanation https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/deployment/sync.go#L183 |
@juandiegopalomino This may make sense as a follow-up to #12409--what do you think? |
@zacharysarah alrighty. It seems like a 1-2 sentence fix (or am I missing something), correct? |
@juandiegopalomino It looks pretty straightforward, just removing deprecated content. I recommend tagging @darkmane for review on the PR. |
cool, on it |
@juandiegopalomino you still on it ? if not let me know and i might have spare cycle to help |
@DanyC97 ^ |
cool, thank you @juandiegopalomino . in which case i guess current issue can be closed ? |
I believe so |
This is a...
Problem:
Deployment documentation incorrectly describes how ReplicaSets are named.
ReplicaSets created by Deployments are no longer named [Deployment Name]-[Pod-template-hash]
Proposed Solution:
Correct how names are generated. I will try and comment with the process once I find it in source code.
Page to Update:
https://kubernetes.io/docs/concepts/workloads/controllers/deployment/
1.9+
The text was updated successfully, but these errors were encountered: