Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zh][Umbrella] Contribution docs to sync for 1.24 #33474

Closed
3 tasks done
tengqm opened this issue May 5, 2022 · 15 comments
Closed
3 tasks done

[zh][Umbrella] Contribution docs to sync for 1.24 #33474

tengqm opened this issue May 5, 2022 · 15 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@tengqm
Copy link
Contributor

tengqm commented May 5, 2022

This is an umbrella issue for contribution docs that are out of sync for zh localization. The difference is captured on 2022-05-05, so the list may become outdated soon. Please do run the scripts/lsync.sh again before working on any issue.

/help

2	2	content/en/docs/contribute/participate/roles-and-responsibilities.md
22	1	content/en/docs/contribute/participate/pr-wranglers.md
**removed**	content/en/docs//contribute/new-content/overview.md
116	0	content/en/docs/contribute/new-content/_index.md
38	0	content/en/docs/contribute/new-content/blogs-case-studies.md
94	6	content/en/docs/contribute/new-content/open-a-pr.md
37	2	content/en/docs/contribute/review/reviewing-prs.md
89	4	content/en/docs/contribute/_index.md
@tengqm tengqm added the kind/feature Categorizes issue or PR as related to a new feature. label May 5, 2022
@k8s-ci-robot
Copy link
Contributor

@tengqm:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

This is an umbrella issue for contribution docs that are out of sync for zh localization. The difference is captured on 2022-05-05, so the list may become outdated soon. Please do run the scripts/lsync.sh again before working on any issue.

/help

  • contribution-1
2	2	content/en/docs/contribute/participate/roles-and-responsibilities.md
22	1	content/en/docs/contribute/participate/pr-wranglers.md
**removed**	content/en/docs//contribute/new-content/overview.md
116	0	content/en/docs/contribute/new-content/_index.md
  • contribution-2
38	0	content/en/docs/contribute/new-content/blogs-case-studies.md
94	6	content/en/docs/contribute/new-content/open-a-pr.md
  • contribution-3
37	2	content/en/docs/contribute/review/reviewing-prs.md
89	4	content/en/docs/contribute/_index.md

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label May 5, 2022
@k8s-ci-robot
Copy link
Contributor

@tengqm: This issue is currently awaiting triage.

SIG Docs takes a lead on issue triage for this website, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label May 5, 2022
This was referenced May 5, 2022
@windsonsea
Copy link
Member

windsonsea commented May 11, 2022

/triage accepted

@windsonsea
Copy link
Member

I need check those 8 md files line by line. If any inconsistency between en and cn, I need change them, correct?

@tengqm
Copy link
Contributor Author

tengqm commented May 11, 2022

@windsonsea You may find the scripts/lsync.sh tool useful. For example, run the following command on the main branch:

./scripts/lsync.sh content/zh/docs/contribute/participate/roles-and-responsibilities.md

It will show you the changes to the upstream English source since the last time that page was sync'ed (or translated).
Basically, those changes are the lines we need to resync to Chinese.

@tengqm
Copy link
Contributor Author

tengqm commented May 11, 2022

@windsonsea Maybe you can start by working on the first item?

@windsonsea
Copy link
Member

./scripts/lsync.sh content/zh/docs/contribute/participate/roles-and-responsibilities.md

hmmm, I runned this command on the main branch in VScode but nothing happened -_! Could you join a WeMeet like room no: 323-315-205

@tengqm
Copy link
Contributor Author

tengqm commented May 11, 2022

$ ./scripts/lsync.sh content/zh/docs/contribute/participate/roles-and-responsibilities.md
diff --git a/content/en/docs/contribute/participate/roles-and-responsibilities.md b/content/en/docs/contribute/participate/roles-and-responsibilities.md
index e59ffe4fe3..c577c3f8be 100644
--- a/content/en/docs/contribute/participate/roles-and-responsibilities.md
+++ b/content/en/docs/contribute/participate/roles-and-responsibilities.md
@@ -147,7 +147,7 @@ separately for reviewer status in SIG Docs.
 To apply:
 
 1. Open a pull request that adds your GitHub user name to a section of the
-   [OWNERS_ALIASES](https://github.com/kubernetes/website/blob/main/OWNERS) file
+   [OWNERS_ALIASES](https://github.com/kubernetes/website/blob/main/OWNERS_ALIASES) file
    in the `kubernetes/website` repository.
 
    {{< note >}}
@@ -219,7 +219,7 @@ separately for approver status in SIG Docs.
 To apply:
 
 1. Open a pull request adding yourself to a section of the
-   [OWNERS_ALIASES](https://github.com/kubernetes/website/blob/main/OWNERS)
+   [OWNERS_ALIASES](https://github.com/kubernetes/website/blob/main/OWNERS_ALIASES)
    file in the `kubernetes/website` repository.
 
     {{< note >}}

@windsonsea
Copy link
Member

windsonsea commented May 11, 2022

One question: How can I assign my PR to you? My PR comment is like:

Accepted a task #33474 to check zh text from @tengqm. This is the first md file in the list. I'm not familiar with using the scripts/lsync.sh, so perform a proofreading word by word. Most changes are for context consistency. Hope the reader can read a same word in a page instead of confusing with why those words are different, such as a link name PR 管理者 before/after a click. /assign @tengqm

@windsonsea
Copy link
Member

contribution-1 is completed and a PR is opened right now. I will continue to handle contribution-2 and -3.

@tengqm
Copy link
Contributor Author

tengqm commented May 12, 2022

contribution-1 is completed and a PR is opened right now. I will continue to handle contribution-2 and -3.

Assigned.

@windsonsea
Copy link
Member

Up to now, those files of contribution-1 and -2 are completed and merged, and contribution-3 is submitted in PR#33677 for your review. If you need any more support, just message me :)

@tengqm
Copy link
Contributor Author

tengqm commented May 16, 2022

@windsonsea We usually do not assign tasks to contributors. We hope our fellow contributors are signing on issues voluntarily. There are a few umbrella issues like #33474#33475#33476#33477#33478#33479. These are filed for a bigger effort after the v1.24 release. There are other localization issues to be closed. You can find them by filtering the issues by the language/zh tag.

@tengqm
Copy link
Contributor Author

tengqm commented May 16, 2022

This issue is done.
/close

@k8s-ci-robot
Copy link
Contributor

@tengqm: Closing this issue.

In response to this:

This issue is done.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

No branches or pull requests

3 participants