Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update slack-infra jobs to use go1.23 #33939

Merged
merged 1 commit into from
Dec 13, 2024
Merged

update slack-infra jobs to use go1.23 #33939

merged 1 commit into from
Dec 13, 2024

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Dec 12, 2024 •
edited
Loading

need for kubernetes-sigs/slack-infra#68

also the current image does not exist anymore

/assign @jeefy @Katharine @nikhita

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 12, 2024
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/jobs sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Dec 12, 2024
@cpanato cpanato mentioned this pull request Dec 12, 2024
Open
@BenTheElder
Copy link
Member

@Katharine doesn't work on kubernetes anymore (hasn't for years) xref kubernetes-sigs/slack-infra#67

Once this is on go 1.22+ (or was it 21?) bumping the image will be an optimization and we can rely on gotoolchain to update it in the slack-infra repo.

@cpanato
Copy link
Member Author

cpanato commented Dec 12, 2024

I will update the onwers file in a follow up

@cpanato cpanato requested a review from BenTheElder December 13, 2024 13:03
BenTheElder
BenTheElder reviewed Dec 13, 2024
View reviewed changes
config/jobs/kubernetes-sigs/slack-infra/slack-infra-config.yaml
@@ -7,7 +7,8 @@ presubmits:
always_run: true
spec:
containers:
- image: public.ecr.aws/docker/library/golang:1.11.5
- image: public.ecr.aws/docker/library/golang:1.23
imagePullPolicy: Always
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is going to be slow but OK

FWIW I again recommend controlling the version with toolchain in the source repo

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're considering prohibiting this #33868

BenTheElder
BenTheElder reviewed Dec 13, 2024
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 13, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, cpanato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2024
@k8s-ci-robot k8s-ci-robot merged commit 8120bc9 into kubernetes:master Dec 13, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@cpanato: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key slack-infra-config.yaml using file config/jobs/kubernetes-sigs/slack-infra/slack-infra-config.yaml

In response to this:

need for kubernetes-sigs/slack-infra#68

also the current image does not exist anymore

/assign @jeefy @Katharine @nikhita

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cpanato cpanato deleted the update-slack-infra branch December 13, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder left review comments

@jeefy jeefy Awaiting requested review from jeefy

@Katharine Katharine Awaiting requested review from Katharine

Assignees

@Katharine Katharine

@BenTheElder BenTheElder

@jeefy jeefy

@nikhita nikhita

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cpanato @BenTheElder @k8s-ci-robot @Katharine @jeefy @nikhita