Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

job: migrate cluster-api-provider-openstack jobs to community cluster #31982

Merged
merged 1 commit into from
Feb 27, 2024
Merged

job: migrate cluster-api-provider-openstack jobs to community cluster #31982

merged 1 commit into from
Feb 27, 2024

Conversation

jongwooo
Copy link
Member

This PR migrate cluster-api-provider-openstack jobs to community cluster.
Fixes part of #31791

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 14, 2024
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 14, 2024
@rjsadow
Copy link
Contributor

rjsadow commented Feb 16, 2024

Hey @jongwooo These jobs will need to run on the k8s-infra-prow-build cluster.

@mdbooth
Copy link
Contributor

mdbooth commented Feb 21, 2024

Is there any way to rehearse these jobs on the new cluster? As mentioned on another PR, the e2e jobs make explicit use of GCP. Unless those GCP credentials are also available on the community cluster I would not expect them to work.

@rjsadow
Copy link
Contributor

rjsadow commented Feb 21, 2024

@mdbooth we could make a duplicate canay job that's the same, but on the new cluster and allowed to fail.

@lentzi90
Copy link
Contributor

/hold
#31791 (comment)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 27, 2024
@lentzi90
Copy link
Contributor

Based on #31791 (comment) I think we can proceed.
/hold cancel
/approve

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 27, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jongwooo, lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2024
@lentzi90 lentzi90 mentioned this pull request Feb 27, 2024
Closed
21 tasks
@ameukam
Copy link
Member

ameukam commented Feb 27, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2024
@k8s-ci-robot k8s-ci-robot merged commit a4b087b into kubernetes:master Feb 27, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@jongwooo: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key cluster-api-provider-openstack-periodics.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-openstack/cluster-api-provider-openstack-periodics.yaml
  • key cluster-api-provider-openstack-presubmits.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-openstack/cluster-api-provider-openstack-presubmits.yaml

In response to this:

This PR migrate cluster-api-provider-openstack jobs to community cluster.
Fixes part of #31791

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jongwooo jongwooo deleted the migrate-cluster-api-provider-openstack-jobs-to-community-cluster branch February 27, 2024 12:38
This was referenced Feb 27, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jichenjc jichenjc Awaiting requested review from jichenjc

@mdbooth mdbooth Awaiting requested review from mdbooth

Assignees

@ameukam ameukam

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jongwooo @rjsadow @mdbooth @lentzi90 @k8s-ci-robot @ameukam