Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate remaining sig-cluster-lifecycle jobs to community cluster #31791

Closed
21 tasks done
rjsadow opened this issue Feb 1, 2024 · 20 comments
Closed
21 tasks done

Migrate remaining sig-cluster-lifecycle jobs to community cluster #31791

rjsadow opened this issue Feb 1, 2024 · 20 comments
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/testing Categorizes an issue or PR as relevant to SIG Testing.

Comments

@rjsadow
Copy link
Contributor

rjsadow commented Feb 1, 2024

The following jobs still run on the default google owned cluster and need to be migrated to a community cluster

cluster-api-provider-openstack

  • pull-cluster-api-provider-openstack-e2e-test | Search Results |
  • pull-cluster-api-provider-openstack-conformance-test | Search Results |
  • pull-cluster-api-provider-openstack-e2e-full-test | Search Results |
  • periodic-cluster-api-provider-openstack-e2e-test-main | Search Results |
  • periodic-cluster-api-provider-openstack-conformance-test-main-with-k8s-ci-art | Search Results |
  • periodic-cluster-api-provider-openstack-e2e-full-test-main | Search Results |

cluster-api-addon-provider-helm

  • periodic-cluster-api-addon-provider-helm-capi-e2e-main | Search Results |
  • periodic-cluster-api-addon-provider-helm-e2e-workload-upgrade-main
  • periodic-cluster-api-addon-provider-helm-apiversion-upgrade-main
  • periodic-cluster-api-addon-provider-helm-e2e
  • pull-cluster-api-addon-provider-helm-e2e
  • pull-cluster-api-addon-provider-helm-e2e-workload-upgrade
  • pull-cluster-api-addon-provider-helm-apiversion-upgrade

cluster-api-provider-azure

cluster-api-provider-ibmcloud

cluster-api-provider-cloudstack

  • capi-provider-cloudstack-presubmit-e2e-smoke-test | Search Results |

image-builder

kubeadm

/sig testing
/sig k8s-infra

@rjsadow rjsadow added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Feb 1, 2024
@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. labels Feb 1, 2024
@rjsadow
Copy link
Contributor Author

rjsadow commented Feb 1, 2024

/sig cluster-lifecycle

@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Feb 1, 2024
@rjsadow rjsadow changed the title Migrate remaining capi jobs to community cluster Migrate remaining sig-cluster-lifecycle jobs to community cluster Feb 1, 2024
@ameukam
Copy link
Member

ameukam commented Feb 2, 2024

/help
/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@ameukam:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/help
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Feb 2, 2024
@jongwooo
Copy link
Member

jongwooo commented Feb 11, 2024

I would like to work on image-builder job.

/assign

@jongwooo
Copy link
Member

I would like to work on cluster-api-provider-openstack jobs.

@reetasingh
Copy link
Contributor

I have opened a PR for capi-provider-cloudstack-presubmit-e2e-smoke-test job #31980

@jongwooo
Copy link
Member

I would like to work on cluster-api-provider-azure jobs.

@nitishfy
Copy link
Member

I'd like to work on cluster-api-addon-provider-helm job

@jongwooo
Copy link
Member

I would like to work on cluster-api-provider-ibmcloud job.

@Devaansh-Kumar
Copy link
Contributor

I would like to work on cluster-api-provider-cloudstack job

@lentzi90
Copy link
Contributor

lentzi90 commented Feb 27, 2024

Hi!
I am a maintainer of cluster-api-provider-openstack.
All remaining *cluster-api-provider-openstack* jobs rely on boskos and GCP for cloud resources and need credentials for that. I got the impression earlier that these kinds of jobs could not easily be migrated and that is why I left them. I see people opening PRs to move them now and I would like confirmation that this is indeed possible. We obviously do not want to break all our e2e tests by mistake.

Please do not attempt to move the jobs without first ensuring that they will work. We could for example duplicate one of them and make it optional. Then confirm that it is working before we continue with the move.

CC @mdbooth

Edit: I have put hold on all referenced PRs and linked to this comment.

@ameukam
Copy link
Member

ameukam commented Feb 27, 2024

Hi! I am a maintainer of cluster-api-provider-openstack. All remaining *cluster-api-provider-openstack* jobs rely on boskos and GCP for cloud resources and need credentials for that. I got the impression earlier that these kinds of jobs could not easily be migrated and that is why I left them. I see people opening PRs to move them now and I would like confirmation that this is indeed possible. We obviously do not want to break all our e2e tests by mistake.

Please do not attempt to move the jobs without first ensuring that they will work. We could for example duplicate one of them and make it optional. Then confirm that it is working before we continue with the move.

CC @mdbooth

Edit: I have put hold on all referenced PRs and linked to this comment.

@lentzi90 what are the technical blockers of this migration ?
Since we don't have access to the Google infrastructure, we have currently have no visibility on the requirements of those jobs.

@lentzi90
Copy link
Contributor

I am not sure how exactly it works, not even if it is an issue, but I want to be sure before we do the move.

What I do know is that these jobs use boskos to set up GCP resources where the tests run. I'm not sure how the credentials for this are handled. They could be in the prow cluster for example or the jobs could get access simply because they run in that particular cluster. If the credentials are not available in the community cluster, then we would not get the GCP resources and the jobs would fail.

To be perfectly clear, I do understand that we need to move and I want to help. I think we can make a duplicate optional job in the community cluster to test things out. When we see that it is working we can continue with the move.

@ameukam
Copy link
Member

ameukam commented Feb 27, 2024

I am not sure how exactly it works, not even if it is an issue, but I want to be sure before we do the move.

What I do know is that these jobs use boskos to set up GCP resources where the tests run. I'm not sure how the credentials for this are handled. They could be in the prow cluster for example or the jobs could get access simply because they run in that particular cluster. If the credentials are not available in the community cluster, then we would not get the GCP resources and the jobs would fail.

To be perfectly clear, I do understand that we need to move and I want to help. I think we can make a duplicate optional job in the community cluster to test things out. When we see that it is working we can continue with the move.

@lentzi90 All of what you described already exists in the community infrastructure. And we already had multiple canary jobs to validate that the credentials (defined as presets) are working post-migration.

@lentzi90
Copy link
Contributor

lentzi90 commented Feb 27, 2024

Awesome! If that is so then I see no issues with proceeding. My understanding was based on #29722

All jobs in the Prow Default Cluster that do not depend on external cloud assets should attempt migrate to cluster: eks-prow-build-cluster.

NOTE: if you see any entries under label that says gce skip this job and go to the next time as this is not ready to be moved yet.

@ameukam
Copy link
Member

ameukam commented Feb 27, 2024

@lentzi90 Can take you a look at the PRs open and approve them ?

@lentzi90
Copy link
Contributor

I have approved #31982 which was the first one. I think it covers all the jobs so the other PRs for CAPO will not be needed.

@varaynya
Copy link
Contributor

varaynya commented Mar 1, 2024

@ameukam: This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to this:

/help
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ameukam @lentzi90
first time contributor here. I'd really appreciate if the above mentioned guidelines are added to the issue, it will help me get the whole picture.

@esotsal
Copy link

esotsal commented Mar 6, 2024

I would like to work on periodic-cluster-api-addon-provider-helm-capi-e2e-main, periodic-cluster-api-addon-provider-helm-apiversion-upgrade-main and periodic-cluster-api-addon-provider-helm-e2e jobs

varaynya added a commit to varaynya/test-infra that referenced this issue Mar 6, 2024
…s#31791

migrate  pull-cluster-api-addon-provider-helm-e2e, -e2e-workload-upgrade, -apiversion-upgrade to community cluster
@ameukam
Copy link
Member

ameukam commented Mar 11, 2024

@rjsadow I think we are good to close this ?

@rjsadow rjsadow closed this as completed Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
None yet
Development

No branches or pull requests

10 participants