Prevent clients created with GitHubOptions.GitClientFactory from leaking secrets

[oliver-goetz]

/sig testing
/area prow
/kind bug

Git clients created with GitHubOptions.GitClientFactory can leak secrets when they use Github Authentication.
This happens because the token is added to the secrets manager, but GitClientFactory does not add a Censor to its options.
The base options of githubClient adds secret.Censor, so this PR does the same for GitClientFactory.
In the current implementation when no Censor is specified, the default options create a noop Censor.

When you check logs of cherrypicker, you might find some github tokens.

[k8s-ci-robot]

Hi @oliver-goetz. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jmguzik]

/ok-to-test

[petr-muller]

LGTM, thanks!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oliver-goetz, petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• prow/OWNERS [petr-muller]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment