Merge pull request #31350 from oliver-goetz/fix/prevent-gitclientfact…

…ory-leaking-secrets Prevent clients created with `GitHubOptions.GitClientFactory` from leaking secrets
kubernetes · Dec 6, 2023 · 39862d7 · 39862d7
2 parents 46b97e4 + d7514b3
commit 39862d7
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/prow/flagutil/github.go b/prow/flagutil/github.go
@@ -337,6 +337,7 @@ func (o *GitHubOptions) GitHubClientWithAccessToken(token string) (github.Client
 // github.go.
 func (o *GitHubOptions) GitClientFactory(cookieFilePath string, cacheDir *string, dryRun, persistCache bool) (gitv2.ClientFactory, error) {
 	opts := gitv2.ClientFactoryOpts{
+		Censor:         secret.Censor,
 		CookieFilePath: cookieFilePath,
 		Host:           o.Host,
 		Persist:        &persistCache,