-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add release-1.6 test jobs #31290
add release-1.6 test jobs #31290
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: nawazkh The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
- add release-1.6-periodics jobs - add release-1.6-periodics-upgrade jobs - add release-1.6-presubmit jobs - add dashboard groups for release-1.6
bd609c3
to
e2c4a49
Compare
@@ -8,6 +8,7 @@ dashboard_groups: | |||
- sig-cluster-lifecycle-cluster-api-1.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we remove some of the older release jobs? How come we are testing so many release branches?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have maintained release-1.3 to gauge the performance of test-infra on EKS Community Clusters and release-1.3 was the set of jobs migrated to use EKS Community clusters.
Nonetheless, you are right, we should be dropping release-1.3 and port over release-1.4 onto the EKS community cluster or drop release-1.4 altogether and maintain release-1.3 test jobs.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found the PR moving release-1.4 to EKS Community cluster.
#30365
So I think yes, we should be dropping the release-1.3 jobs from the set of test jobs being maintained.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kranurag7 Are we planning on porting over release-1.4 test jobs onto EKS community cluster and dropping release-1.3 jobs altogether? Was that the planned move?
Nawaz, I just pushed a change where I missed a resource block in one of the jobs.
The 1.4 jobs is tracked here #30365, but you're already aware of that. :)
For continuity of context, if a reviewer is approving this PR, please also take a look at kubernetes-sigs/cluster-api#9756 |
My bad. I just noticed that @adilGhaffarDev has already created a PR creating release-1.6 jobs in here #31208 I will be closing this PR since it is a duplicate. |
/close |
@nawazkh: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR adds CAPI release-1.6 test jobs.