Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add release-1.6 test jobs #31290

Closed

Conversation

nawazkh
Copy link
Contributor

@nawazkh nawazkh commented Nov 21, 2023

This PR adds CAPI release-1.6 test jobs.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs area/testgrid labels Nov 21, 2023
@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 21, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nawazkh
Once this PR has been reviewed and has the lgtm label, please assign neolit123 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

- add release-1.6-periodics jobs
- add release-1.6-periodics-upgrade jobs
- add release-1.6-presubmit jobs
- add dashboard groups for release-1.6
@nawazkh nawazkh force-pushed the capi-release-1.6-test-jobs branch from bd609c3 to e2c4a49 Compare November 21, 2023 17:51
@nawazkh nawazkh marked this pull request as ready for review November 21, 2023 17:51
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 21, 2023
@@ -8,6 +8,7 @@ dashboard_groups:
- sig-cluster-lifecycle-cluster-api-1.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we remove some of the older release jobs? How come we are testing so many release branches?

Copy link
Contributor Author

@nawazkh nawazkh Nov 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have maintained release-1.3 to gauge the performance of test-infra on EKS Community Clusters and release-1.3 was the set of jobs migrated to use EKS Community clusters.
Nonetheless, you are right, we should be dropping release-1.3 and port over release-1.4 onto the EKS community cluster or drop release-1.4 altogether and maintain release-1.3 test jobs.

This comment was marked as resolved.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found the PR moving release-1.4 to EKS Community cluster.
#30365
So I think yes, we should be dropping the release-1.3 jobs from the set of test jobs being maintained.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kranurag7 Are we planning on porting over release-1.4 test jobs onto EKS community cluster and dropping release-1.3 jobs altogether? Was that the planned move?

Nawaz, I just pushed a change where I missed a resource block in one of the jobs.
The 1.4 jobs is tracked here #30365, but you're already aware of that. :)

@nawazkh
Copy link
Contributor Author

nawazkh commented Nov 21, 2023

For continuity of context, if a reviewer is approving this PR, please also take a look at kubernetes-sigs/cluster-api#9756

@nawazkh
Copy link
Contributor Author

nawazkh commented Nov 21, 2023

My bad. I just noticed that @adilGhaffarDev has already created a PR creating release-1.6 jobs in here #31208

I will be closing this PR since it is a duplicate.

@nawazkh
Copy link
Contributor Author

nawazkh commented Nov 21, 2023

/close

@k8s-ci-robot
Copy link
Contributor

@nawazkh: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nawazkh nawazkh deleted the capi-release-1.6-test-jobs branch November 21, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/config Issues or PRs related to code in /config area/jobs area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants