-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add jobs for CAPI release 1.6 #31208
Conversation
/hold |
Hi @adilGhaffarDev. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
@@ -0,0 +1,319 @@ | |||
periodics: | |||
|
|||
- name: periodic-cluster-api-e2e-workload-upgrade-1-22-1-23-release-1-6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like all the new jobs in the PR are not based on the current main branch jobs as described on the release tasks notes? Have you copied these jobs based on the current main jobs, i.e [cluster-api-periodics-release-1-6-upgrades.yaml] needs to be created based on the https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes-sigs/cluster-api/cluster-api-periodics-main-upgrades.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry my bad, now it's fixed.
ebc1d4f
to
e012dd1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good except one clarification question:
@@ -0,0 +1,206 @@ | |||
periodics: | |||
- name: periodic-cluster-api-test-release-1-6 | |||
interval: 4h |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason we need to use longer interval (4h instead of 2h) throughout the file then what we have on main?
cc @sbueringer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I copied it from v1.5, in the release docs it says to copy from v1.3 which is also 4h.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason is that we don't want to waste resources on branches which are relatively stable. release-1.6 won't change that much so we don't need a test every 2 hours
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @adilGhaffarDev!
/lgtm
Perfect! :) /lgtm |
/assign @fabriziopandini |
/lgtm |
/hold Please move those jobs to a community-owned cluster. |
The plan we discussed in the office hours was to move directly after the CAPI v1.6.0 release (which was planned for 28th November). But this hold now blocks the CAPI v1.6.0 release. @furkatgofurov7 Is the plan now to move to the community cluster before the release? If yes, how confident are we that we'll get stable jobs in time for the release or will this further delay the release? (As far as I can tell |
@sbueringer I think the plan was move them one by one at at least initially and move all the remaining jobs at once -> edited the ref link.
@ameukam Based on ^, I would suggest merging this PR as is, and move CAPI jobs gradually to EKS cluster. |
+1 to go on with our plan and not put the move to the community cluster in the critical path for the 1.6 release. |
Looks good to me. /lgtm |
SGTM |
@fabriziopandini Can you please approve for the dashboard part? |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adilGhaffarDev, fabriziopandini, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@adilGhaffarDev: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Add jobs for Cluster API release v1.6. More information about release can found here: