Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jobs for CAPI release 1.6 #31208

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Conversation

adilGhaffarDev
Copy link
Contributor

@adilGhaffarDev adilGhaffarDev commented Nov 8, 2023

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 8, 2023
@adilGhaffarDev
Copy link
Contributor Author

/hold

@k8s-ci-robot
Copy link
Contributor

Hi @adilGhaffarDev. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. area/config Issues or PRs related to code in /config area/jobs area/testgrid sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 8, 2023
@adilGhaffarDev
Copy link
Contributor Author

Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 8, 2023
@@ -0,0 +1,319 @@
periodics:

- name: periodic-cluster-api-e2e-workload-upgrade-1-22-1-23-release-1-6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like all the new jobs in the PR are not based on the current main branch jobs as described on the release tasks notes? Have you copied these jobs based on the current main jobs, i.e [cluster-api-periodics-release-1-6-upgrades.yaml] needs to be created based on the https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes-sigs/cluster-api/cluster-api-periodics-main-upgrades.yaml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry my bad, now it's fixed.

Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except one clarification question:

@@ -0,0 +1,206 @@
periodics:
- name: periodic-cluster-api-test-release-1-6
interval: 4h
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason we need to use longer interval (4h instead of 2h) throughout the file then what we have on main?

cc @sbueringer

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied it from v1.5, in the release docs it says to copy from v1.3 which is also 4h.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason is that we don't want to waste resources on branches which are relatively stable. release-1.6 won't change that much so we don't need a test every 2 hours

Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @adilGhaffarDev!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 14, 2023
@sbueringer
Copy link
Member

Perfect! :)

/lgtm
/approve

@sbueringer
Copy link
Member

/assign @fabriziopandini

@fabriziopandini
Copy link
Member

/lgtm
I will approve as soon as we have a date for the branch creation (see discussion in https://kubernetes.slack.com/archives/C8TSNPY4T/p1699880722395049)

@ameukam
Copy link
Member

ameukam commented Nov 18, 2023

/hold

Please move those jobs to a community-owned cluster.

@sbueringer
Copy link
Member

sbueringer commented Nov 20, 2023

/hold

Please move those jobs to a community-owned cluster.

The plan we discussed in the office hours was to move directly after the CAPI v1.6.0 release (which was planned for 28th November). But this hold now blocks the CAPI v1.6.0 release.

@furkatgofurov7 Is the plan now to move to the community cluster before the release? If yes, how confident are we that we'll get stable jobs in time for the release or will this further delay the release?

(As far as I can tell Job execution failed: Pod got deleted unexpectedly still occurs on the AWS cluster, but if that's the only issue we have we can probably just ignore these kinds of flakes, e.g. last Wednesday: https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/periodic-cluster-api-e2e-mink8s-release-1-3/1724739536589688832)

@furkatgofurov7
Copy link
Member

furkatgofurov7 commented Nov 20, 2023

/hold
Please move those jobs to a community-owned cluster.

The plan we discussed in the office hours was to move directly after the CAPI v1.6.0 release (which was planned for 28th November). But this hold now blocks the CAPI v1.6.0 release.

@furkatgofurov7 Is the plan now to move to the community cluster before the release? If yes, how confident are we that we'll get stable jobs in time for the release or will this further delay the release?

(As far as I can tell Job execution failed: Pod got deleted unexpectedly still occurs on the AWS cluster, but if that's the only issue we have we can probably just ignore these kinds of flakes, e.g. last Wednesday: https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/periodic-cluster-api-e2e-mink8s-release-1-3/1724739536589688832)

@sbueringer I think the plan was move them one by one at at least initially and move all the remaining jobs at once -> edited the ref link.

  1. 1.4 jobs are still running on GCP and we have PR to move them.
  2. 1.3. jobs removal PR is on hold, since it is the only tests we are running on EKS and if we remove we would not have a coverage. Additionally, there is other issue, i.e Job execution failed: Pod got deleted unexpectedly described in NodeNotReady test flakes on Release-1.3 test jobs kubernetes-sigs/cluster-api#9379 which seen in release-1.3 jobs meaning it looks we are still facing issues while running CAPI jobs in EKS cluster.
  3. 1.5 jobs are not moved yet

@ameukam Based on ^, I would suggest merging this PR as is, and move CAPI jobs gradually to EKS cluster.

@fabriziopandini
Copy link
Member

+1 to go on with our plan and not put the move to the community cluster in the critical path for the 1.6 release.
we can restart moving job from older release branches as soon as we are confident the current issue is addressed

@nawazkh
Copy link
Contributor

nawazkh commented Nov 21, 2023

Looks good to me.
And @furkatgofurov7 's explanation in #31208 (comment) seems to be a fair plan.
@ameukam What do you say?

/lgtm

@ameukam
Copy link
Member

ameukam commented Nov 21, 2023

Looks good to me. And @furkatgofurov7 's explanation in #31208 (comment) seems to be a fair plan. @ameukam What do you say?

/lgtm

SGTM
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 21, 2023
@sbueringer
Copy link
Member

@fabriziopandini Can you please approve for the dashboard part?

@fabriziopandini
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adilGhaffarDev, fabriziopandini, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2023
@k8s-ci-robot k8s-ci-robot merged commit 2276843 into kubernetes:master Nov 22, 2023
6 checks passed
@k8s-ci-robot
Copy link
Contributor

@adilGhaffarDev: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key cluster-api-periodics-release-1-6-upgrades.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-periodics-release-1-6-upgrades.yaml
  • key cluster-api-periodics-release-1-6.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-periodics-release-1-6.yaml
  • key cluster-api-presubmits-release-1-6.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-presubmits-release-1-6.yaml

In response to this:

Add jobs for Cluster API release v1.6. More information about release can found here:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Sunnatillo Sunnatillo deleted the capi-v1.6/adil branch April 2, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants