Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont allow undecorated jobs to be merged #30862

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Dont allow undecorated jobs to be merged #30862

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 0 additions & 33 deletions config/jobs/kubernetes/test-infra/test-infra-presubmits.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,39 +87,6 @@ presubmits:
- --warnings=unknown-fields
- --warnings=duplicate-job-refs
- --warnings=unknown-fields-all
resources:
requests:
cpu: "1"
memory: "2Gi"
limits:
cpu: "1"
memory: "2Gi"
annotations:
testgrid-dashboards: presubmits-test-infra
- name: pull-test-infra-prow-checkconfig-loose
cluster: eks-prow-build-cluster
optional: true
decorate: true
skip_report: true
run_if_changed: '^(config/prow/(config|plugins).yaml$|config/jobs/.*.yaml$)'
spec:
containers:
- image: gcr.io/k8s-prow/checkconfig:v20230922-5fbb87c004
command:
- checkconfig
args:
- --config-path=config/prow/config.yaml
- --job-config-path=config/jobs
- --plugin-config=config/prow/plugins.yaml
- --warnings=mismatched-tide-lenient
- --warnings=tide-strict-branch
- --warnings=needs-ok-to-test
- --warnings=validate-owners
- --warnings=missing-trigger
- --warnings=validate-urls
- --warnings=unknown-fields
- --warnings=duplicate-job-refs
- --warnings=unknown-fields-all
- --warnings=non-decorated-jobs
- --warnings=valid-decoration-config
resources:
Expand Down
5 changes: 4 additions & 1 deletion config/jobs/kubernetes/test-infra/test-infra-trusted.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -862,6 +862,9 @@ periodics:
- --warnings=validate-urls
- --warnings=unknown-fields
- --warnings=duplicate-job-refs
- --warnings=unknown-fields-all
Copy link
Member Author

@upodroid upodroid Sep 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unknown fields were fixed last year, but he forgot to add them to the ci job #27584

- --warnings=non-decorated-jobs
- --warnings=valid-decoration-config
resources:
requests:
cpu: "1"
Expand All @@ -871,5 +874,5 @@ periodics:
memory: "2Gi"
annotations:
testgrid-dashboards: sig-testing-misc
testgrid-alert-email: [email protected], k8s-infra-oncall@google.com
testgrid-alert-email: [email protected], k8s-infra-prow-oncall@kubernetes.io
testgrid-num-failures-to-alert: '10'