Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dont allow undecorated jobs to be merged #30862

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Dont allow undecorated jobs to be merged #30862

merged 1 commit into from
Sep 25, 2023

Conversation

upodroid
Copy link
Member

Fixes: #30846
Fixes: #20760
Closes: #30807

/hold

/cc @dims @aojea

@k8s-ci-robot k8s-ci-robot requested a review from aojea September 25, 2023 10:17
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 25, 2023
@k8s-ci-robot k8s-ci-robot requested a review from dims September 25, 2023 10:17
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Sep 25, 2023
upodroid
upodroid commented Sep 25, 2023
View reviewed changes
config/jobs/kubernetes/test-infra/test-infra-trusted.yaml
@@ -862,6 +862,9 @@ periodics:
- --warnings=validate-urls
- --warnings=unknown-fields
- --warnings=duplicate-job-refs
- --warnings=unknown-fields-all
Copy link
Member Author

@upodroid upodroid Sep 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unknown fields were fixed last year, but he forgot to add them to the ci job #27584

@upodroid
Copy link
Member Author

/retest

@dims
Copy link
Member

dims commented Sep 25, 2023

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 25, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2023
@dims
Copy link
Member

dims commented Sep 25, 2023

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 25, 2023
@k8s-ci-robot k8s-ci-robot merged commit 48fa0b9 into kubernetes:master Sep 25, 2023
@k8s-ci-robot
Copy link
Contributor

@upodroid: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key test-infra-presubmits.yaml using file config/jobs/kubernetes/test-infra/test-infra-presubmits.yaml
  • key test-infra-trusted.yaml using file config/jobs/kubernetes/test-infra/test-infra-trusted.yaml

In response to this:

Fixes: #30846
Fixes: #20760
Closes: #30807

/hold

/cc @dims @aojea

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aojea
Copy link
Member

aojea commented Sep 25, 2023

/honk

@k8s-ci-robot
Copy link
Contributor

@aojea:
goose image

In response to this:

/honk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea Awaiting requested review from aojea

@dims dims Awaiting requested review from dims

Assignees

@dims dims

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RIP bootstrap.py Migrate jobs away from deprecated bootstrap usage
4 participants
@upodroid @dims @k8s-ci-robot @aojea