Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAPI: bump jobs for v1.28 #30347

Merged
merged 1 commit into from
Aug 17, 2023
Merged

CAPI: bump jobs for v1.28 #30347

merged 1 commit into from
Aug 17, 2023

Conversation

chrischdi
Copy link
Member

@chrischdi chrischdi commented Aug 10, 2023 •
edited
Loading

According to kubernetes-sigs/cluster-api#8708 : Ensure the jobs are adjusted to provide test coverage according to our support policy:

  • For the main branch and the release branch of the latest supported Cluster API minor release:

    • Add new periodic upgrade job.
    • Adjust presubmit jobs so that we have the latest upgrade jobs available on PRs.

  • For the main branch:

    • periodics & presubmits:

      • Bump KUBEBUILDER_ENVTEST_KUBERNETES_VERSION of the test-mink8s jobs to the new minimum supported management cluster version.

    • periodics:

      • Bump KUBERNETES_VERSION_MANAGEMENT of the e2e-mink8s job to the new minimum supported management cluster version.
      • Drop the oldest upgrade job as the oldest Kubernetes minor version is now out of support.

  • Prior art: Bump cluster-api jobs for v1.25/v1.26 kubernetes/test-infra#27421

TODO:

Relates to kubernetes-sigs/cluster-api#8708

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 10, 2023
@chrischdi chrischdi marked this pull request as draft August 10, 2023 05:53
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Aug 10, 2023
This was referenced Aug 10, 2023
Merged
Closed
@sbueringer
Copy link
Member

/retest

@chrischdi chrischdi marked this pull request as ready for review August 14, 2023 09:52
sbueringer
sbueringer reviewed Aug 14, 2023
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit

config/jobs/kubernetes-sigs/cluster-api/cluster-api-periodics-main.yaml Outdated Show resolved Hide resolved
@sbueringer
Copy link
Member

Also here. I think you can un-draft and hold instead

@chrischdi
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 14, 2023
@chrischdi chrischdi force-pushed the pr-capi-prepare-1-28 branch 2 times, most recently from 67be8a9 to a5899ac Compare August 14, 2023 11:38
killianmuldoon
killianmuldoon reviewed Aug 15, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 15, 2023
@chrischdi
Copy link
Member Author

/hold

Waiting for

/retitle CAPI: bump jobs for v1.28

@k8s-ci-robot k8s-ci-robot changed the title [WIP] CAPI: bump jobs for v1.28 CAPI: bump jobs for v1.28 Aug 16, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 16, 2023
@killianmuldoon killianmuldoon mentioned this pull request Aug 16, 2023
Merged
6 tasks
sbueringer
sbueringer reviewed Aug 16, 2023
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two nits I missed before

config/jobs/kubernetes-sigs/cluster-api/cluster-api-periodics-release-1-5-upgrades.yaml Outdated
testgrid-alert-email: [email protected]
testgrid-num-failures-to-alert: "4"

- name: periodic-cluster-api-e2e-workload-upgrade-1-28-latest-release-1-5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should not add this job to 1.5 as 1.5 will never support Kubernetes 1.29. So we also shouldn't test it and invest time to keep it green

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check if this is documented clear enough in release tasks

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating the docs here:

config/jobs/kubernetes-sigs/cluster-api/cluster-api-presubmits-release-1-5.yaml Outdated Show resolved Hide resolved
@chrischdi chrischdi force-pushed the pr-capi-prepare-1-28 branch from a5899ac to 7428708 Compare August 16, 2023 11:31
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2023
@chrischdi chrischdi force-pushed the pr-capi-prepare-1-28 branch from 7428708 to d9c2acb Compare August 16, 2023 11:39
@sbueringer
Copy link
Member

Thx!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2023
@chrischdi chrischdi mentioned this pull request Aug 16, 2023
Merged
@sbueringer
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 17, 2023
@k8s-ci-robot k8s-ci-robot merged commit 5695349 into kubernetes:master Aug 17, 2023
@k8s-ci-robot
Copy link
Contributor

@chrischdi: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key cluster-api-periodics-main-upgrades.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-periodics-main-upgrades.yaml
  • key cluster-api-periodics-main.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-periodics-main.yaml
  • key cluster-api-periodics-release-1-5-upgrades.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-periodics-release-1-5-upgrades.yaml
  • key cluster-api-presubmits-main.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-presubmits-main.yaml
  • key cluster-api-presubmits-release-1-5.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-presubmits-release-1-5.yaml

In response to this:

According to kubernetes-sigs/cluster-api#8708 : Ensure the jobs are adjusted to provide test coverage according to our support policy:

  • For the main branch and the release branch of the latest supported Cluster API minor release:

    • Add new periodic upgrade job.
    • Adjust presubmit jobs so that we have the latest upgrade jobs available on PRs.

  • For the main branch:

    • periodics & presubmits:

      • Bump KUBEBUILDER_ENVTEST_KUBERNETES_VERSION of the test-mink8s jobs to the new minimum supported management cluster version.

    • periodics:

      • Bump KUBERNETES_VERSION_MANAGEMENT of the e2e-mink8s job to the new minimum supported management cluster version.
      • Drop the oldest upgrade job as the oldest Kubernetes minor version is now out of support.

  • Prior art: Bump cluster-api jobs for v1.25/v1.26 kubernetes/test-infra#27421

TODO:

Relates to kubernetes-sigs/cluster-api#8708

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chrischdi chrischdi deleted the pr-capi-prepare-1-28 branch August 17, 2023 09:21
This was referenced Aug 17, 2023
Merged
Merged
@killianmuldoon killianmuldoon mentioned this pull request Oct 19, 2023
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killianmuldoon killianmuldoon killianmuldoon left review comments

@sbueringer sbueringer sbueringer left review comments

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@sbueringer sbueringer

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chrischdi @sbueringer @k8s-ci-robot @killianmuldoon