Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 .github: improve kubernetes bump issue template #9209

Merged
merged 1 commit into from
Aug 17, 2023
Merged

📖 .github: improve kubernetes bump issue template #9209

merged 1 commit into from
Aug 17, 2023

Conversation

chrischdi
Copy link
Member

What this PR does / why we need it:

After working on:

this fixes or clarifies some points in the template for the test jobs and makes it more accurate. Also updates the prior art links.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

/area documentation

@k8s-ci-robot k8s-ci-robot added area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 16, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 16, 2023
@chrischdi chrischdi mentioned this pull request Aug 16, 2023
Merged
1 task
killianmuldoon
killianmuldoon reviewed Aug 16, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @kubernetes-sigs/cluster-api-release-team

@k8s-ci-robot
Copy link
Contributor

@killianmuldoon: GitHub didn't allow me to request PR reviews from the following users: kubernetes-sigs/cluster-api-release-team.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @kubernetes-sigs/cluster-api-release-team

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chrischdi
Copy link
Member Author

chrischdi commented Aug 16, 2023 •
edited
Loading

Cross-checking if there is a general issue on 1-27-latest vs #9160

/test pull-cluster-api-e2e-workload-upgrade-1-27-latest-main

@chrischdi chrischdi mentioned this pull request Aug 16, 2023
Merged
6 tasks
@nawazkh
Copy link
Member

nawazkh commented Aug 16, 2023 •
edited
Loading

/lgtm

furkatgofurov7
furkatgofurov7 reviewed Aug 17, 2023
View reviewed changes
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, few suggestions below:

.github/ISSUE_TEMPLATE/kubernetes_bump.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/kubernetes_bump.md Outdated Show resolved Hide resolved
@chrischdi chrischdi force-pushed the pr-improve-k8s-bump branch from e230570 to 2b62b3f Compare August 17, 2023 11:21
killianmuldoon
killianmuldoon reviewed Aug 17, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 17, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1894dfa030bab15a43b54d0affaf64ab2feeaf6a

furkatgofurov7
furkatgofurov7 reviewed Aug 17, 2023
View reviewed changes
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

/lgtm

sbueringer
sbueringer reviewed Aug 17, 2023
View reviewed changes
.github/ISSUE_TEMPLATE/kubernetes_bump.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/kubernetes_bump.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/kubernetes_bump.md Outdated Show resolved Hide resolved
@chrischdi chrischdi force-pushed the pr-improve-k8s-bump branch from 2b62b3f to 27d62e8 Compare August 17, 2023 14:17
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 17, 2023
@chrischdi chrischdi force-pushed the pr-improve-k8s-bump branch from 27d62e8 to 990f496 Compare August 17, 2023 14:19
@fabriziopandini
Copy link
Member

Thanks for updating this doc!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 17, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b854ad81ffbf7d7259534dda0204198ed1bf8a56

@killianmuldoon
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 17, 2023
@k8s-ci-robot k8s-ci-robot merged commit 9c3da1f into kubernetes-sigs:main Aug 17, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Aug 17, 2023
@sbueringer
Copy link
Member

Thx

/lgtm

@chrischdi chrischdi deleted the pr-improve-k8s-bump branch August 17, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@furkatgofurov7 furkatgofurov7 Awaiting requested review from furkatgofurov7

@killianmuldoon killianmuldoon Awaiting requested review from killianmuldoon

Assignees

@fabriziopandini fabriziopandini

@furkatgofurov7 furkatgofurov7

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.
7 participants
@chrischdi @k8s-ci-robot @nawazkh @fabriziopandini @killianmuldoon @sbueringer @furkatgofurov7