Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove service account and increase resource limit for CAAPH presubmit jobs #30018

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

Jont828
Copy link
Contributor

@Jont828 Jont828 commented Jul 7, 2023

Follow up to #29894 where pods failed to start in CAAPH presubmit jobs due to the service account being missing.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 7, 2023
@k8s-ci-robot k8s-ci-robot requested review from chases2 and dims July 7, 2023 03:48
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jont828

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 7, 2023
@Jont828
Copy link
Contributor Author

Jont828 commented Jul 7, 2023

@ameukam @iftachk How does this look?

@iftachk
Copy link
Contributor

iftachk commented Jul 7, 2023

/lgtm

@k8s-ci-robot
Copy link
Contributor

@iftachk: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ameukam
Copy link
Member

ameukam commented Jul 7, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 7, 2023
@k8s-ci-robot k8s-ci-robot merged commit adb69d5 into kubernetes:master Jul 7, 2023
@k8s-ci-robot
Copy link
Contributor

@Jont828: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key cluster-api-addon-provider-helm-presubmits-main.yaml using file config/jobs/kubernetes-sigs/cluster-api-addon-provider-helm/cluster-api-addon-provider-helm-presubmits-main.yaml

In response to this:

Follow up to #29894 where pods failed to start in CAAPH presubmit jobs due to the service account being missing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants