Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate kubernetes/cluster-api-addon-provider-helm jobs to eks cluster #29894

Merged
merged 1 commit into from
Jun 26, 2023
Merged

migrate kubernetes/cluster-api-addon-provider-helm jobs to eks cluster #29894

merged 1 commit into from
Jun 26, 2023

Conversation

iftachk
Copy link
Contributor

@iftachk iftachk commented Jun 21, 2023

jobs: migrate kubernetes/cluster-api-addon-provider-helm jobs to eks cluster

  • Add missing resource blocks
  • remove unused decoration_config

/priority important-longterm
/area jobs

Part of #29722

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 21, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @iftachk. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/config Issues or PRs related to code in /config sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 21, 2023
@k8s-ci-robot k8s-ci-robot requested review from chases2 and wojtek-t June 21, 2023 14:03
@rjsadow
Copy link
Contributor

rjsadow commented Jun 22, 2023

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 22, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 22, 2023
@iftachk
jobs: migrate kubernetes/cluster-api-addon-provider-helm jobs to eks …
e54946d 
…cluster

- Add missing resource blocks
- remove unused decoration_config

Signed-off-by: Iftach Konshtok <[email protected]>
@iftachk iftachk force-pushed the migrate-cluster-api-addon-provider-helm-jobs branch from 2a14042 to e54946d Compare June 22, 2023 13:35
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 22, 2023
@ameukam
Copy link
Member

ameukam commented Jun 26, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 26, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, iftachk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2023
@k8s-ci-robot k8s-ci-robot merged commit 72d82ab into kubernetes:master Jun 26, 2023
@k8s-ci-robot
Copy link
Contributor

@iftachk: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key cluster-api-addon-provider-helm-presubmits-main.yaml using file config/jobs/kubernetes-sigs/cluster-api-addon-provider-helm/cluster-api-addon-provider-helm-presubmits-main.yaml

In response to this:

jobs: migrate kubernetes/cluster-api-addon-provider-helm jobs to eks cluster

  • Add missing resource blocks
  • remove unused decoration_config

/priority important-longterm
/area jobs

Part of #29722

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Jun 26, 2023
Closed
Closed
@iftachk
Copy link
Contributor Author

iftachk commented Jul 6, 2023 •
edited
Loading

@Jont828 has reported an issue with the migrated cluster-api-addon-provider-helm jobs.
It seems that the pods for the jobs cannot be created since the prowjob-default-sa service account does not exist in the new cluster. @rjsadow @ameukam @xmudrii any recommendation?
Revert the PR / Remove the serviceAccountName config on the migrated jobs

@ameukam
Copy link
Member

ameukam commented Jul 6, 2023

@Jont828 has reported an issue with the migrated cluster-api-addon-provider-helm jobs. It seems that the pods for the jobs cannot be created since the prowjob-default-sa service account does not exist in the new cluster. @rjsadow @ameukam @xmudrii any recommendation? Revert the PR / Remove the serviceAccountName config on the migrated jobs

We can try to remove the service account.

@Jont828 Jont828 mentioned this pull request Jul 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chases2 chases2 Awaiting requested review from chases2

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@ameukam ameukam

@rjsadow rjsadow

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iftachk @k8s-ci-robot @rjsadow @ameukam