Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAPI Operator: move jobs to EKS prow cluster #29743

Merged
merged 1 commit into from
Jun 14, 2023
Merged

CAPI Operator: move jobs to EKS prow cluster #29743

merged 1 commit into from
Jun 14, 2023

Conversation

furkatgofurov7
Copy link
Member

@furkatgofurov7 furkatgofurov7 commented Jun 9, 2023 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 9, 2023
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 9, 2023
@furkatgofurov7 furkatgofurov7 force-pushed the move-operator-jobs-to-eksprow-cluster branch from 713cac3 to 04912e8 Compare June 9, 2023 13:16
@furkatgofurov7
Copy link
Member Author

/cc @Fedosin @alexander-demicev @JoelSpeed
/hold cancel

@k8s-ci-robot k8s-ci-robot requested a review from Fedosin June 12, 2023 08:28
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jun 12, 2023
@Fedosin
Copy link
Contributor

Fedosin commented Jun 12, 2023

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 12, 2023
@Fedosin
Copy link
Contributor

Fedosin commented Jun 12, 2023

/hold

didn't notice #29743 (comment)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 12, 2023
@ameukam
Copy link
Member

ameukam commented Jun 13, 2023

@furkatgofurov7 Can you please rebase this PR ?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 13, 2023
@furkatgofurov7 furkatgofurov7 force-pushed the move-operator-jobs-to-eksprow-cluster branch from 04912e8 to 19ae37f Compare June 13, 2023 20:53
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 13, 2023
@furkatgofurov7 furkatgofurov7 requested a review from rjsadow June 13, 2023 21:02
@furkatgofurov7
Copy link
Member Author

furkatgofurov7 commented Jun 13, 2023 •
edited
Loading

didn't notice #29743 (comment)

I think we are good to go ahead with current resource quotas. I will be watching the jobs after this PR is merged and increase it if need arises.

/hold cancel

cc @Fedosin

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 13, 2023
@furkatgofurov7
Copy link
Member Author

/cc @dims

@k8s-ci-robot k8s-ci-robot requested a review from dims June 13, 2023 21:04
@ameukam
Copy link
Member

ameukam commented Jun 14, 2023

@furkatgofurov7 Please keep an eye of those jobs for a few days.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 14, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, furkatgofurov7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2023
@k8s-ci-robot k8s-ci-robot merged commit 8131796 into kubernetes:master Jun 14, 2023
@k8s-ci-robot
Copy link
Contributor

@furkatgofurov7: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key cluster-api-operator-periodics-main.yaml using file config/jobs/kubernetes-sigs/cluster-api-operator/cluster-api-operator-periodics-main.yaml
  • key cluster-api-operator-periodics-release-0-3.yaml using file config/jobs/kubernetes-sigs/cluster-api-operator/cluster-api-operator-periodics-release-0-3.yaml
  • key cluster-api-operator-presubmits-main.yaml using file config/jobs/kubernetes-sigs/cluster-api-operator/cluster-api-operator-presubmits-main.yaml
  • key cluster-api-operator-presubmits-release-0-3.yaml using file config/jobs/kubernetes-sigs/cluster-api-operator/cluster-api-operator-presubmits-release-0-3.yaml

In response to this:

Fixes: kubernetes-sigs/cluster-api-operator#152
Part of: kubernetes-sigs/cluster-api-operator#153
Related to: #29722

/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

furkatgofurov7
furkatgofurov7 commented Jun 14, 2023
View reviewed changes
config/jobs/kubernetes-sigs/cluster-api-operator/cluster-api-operator-presubmits-main.yaml
annotations:
testgrid-dashboards: sig-cluster-lifecycle-cluster-api-operator
testgrid-tab-name: capi-operator-pr-test-main
- name: pull-cluster-api-operator-e2e-main
cluster: eks-prow-build-cluster
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ameukam After the merge, this job started failing in kubernetes-sigs/cluster-api-operator#143. Looking at the build logs in https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api-operator/143/pull-cluster-api-operator-e2e-main/1668941993025212416 I don't find anything useful and just:

Job execution failed: Pod pending timeout.
Failed to open /logs/process-log.txt: open /logs/process-log.txt: no such file or directory

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like an issue with the build cluster. Let me ping folx on Slack.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, please tag me in the thread if possible

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 I'd love to follow along too. There have been a few merged jobs transitioning that have had issues so far.

This was referenced Jun 14, 2023
Merged
Merged
@furkatgofurov7 furkatgofurov7 deleted the move-operator-jobs-to-eksprow-cluster branch June 14, 2023 12:37
@furkatgofurov7 furkatgofurov7 mentioned this pull request Jun 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ameukam ameukam ameukam left review comments

@alexander-demicev alexander-demicev Awaiting requested review from alexander-demicev

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@Fedosin Fedosin Awaiting requested review from Fedosin

@rjsadow rjsadow Awaiting requested review from rjsadow

@dims dims Awaiting requested review from dims

Assignees

@ameukam ameukam

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate operator prow jobs to EKS (Community) clusters
5 participants
@furkatgofurov7 @Fedosin @ameukam @k8s-ci-robot @rjsadow