-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Increase golangci-lint timeout to 10 minutes #163
Conversation
We have a separate github action for linting, so running it again is not necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 8e42c60816cd5d77d7177557344dac55ad62434c
|
@Fedosin thanks for the PR. This is the post affect after we merged kubernetes/test-infra#29743. To fix it in infra side itself I pushed kubernetes/test-infra#29804, PTAL. We can take this one too I guess, but if memory increasing helps it might not be needed, so holding this for now. /hold |
@furkatgofurov7 ah, okay! good to know. Probably I can remove the timeout commit, but the other two are useful. |
kubernetes/test-infra#29743 is merged and should fix both e2e main and make main jobs /retest |
@furkatgofurov7 seems like we have to increase timeout anyway: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api-operator/143/pull-cluster-api-operator-make-main/1668960250612420608 |
@Fedosin timeout is still happening even though I bumped the memory for the job: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api-operator/143/pull-cluster-api-operator-make-main/1668960250612420608 which is strange, since in previous infra cluster where job was running it was fine. Maybe it takes more time to run the jobs in new eks prow cluster, and since it is passing here, let's not remove the timeout commit and take this in asap to unblock the CI. |
/hold cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexander-demicev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We need to cherry-pick this, since we will be hitting the same in release-0.3 branch (CI is running in both release-0.3 and main branches) /cherry-pick release-0.3 |
@furkatgofurov7: new pull request created: #164 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
The default timeout is 5 minutes which is not enough sometimes to run all lint checks. Let's bump it to 10 minutes.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #