Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Increase golangci-lint timeout to 10 minutes #163

Merged
merged 3 commits into from
Jun 14, 2023

Conversation

Fedosin
Copy link
Contributor

@Fedosin Fedosin commented Jun 14, 2023

What this PR does / why we need it:

The default timeout is 5 minutes which is not enough sometimes to run all lint checks. Let's bump it to 10 minutes.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 14, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 14, 2023
We have a separate github action for linting, so running it again
is not necessary.
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 14, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8e42c60816cd5d77d7177557344dac55ad62434c

@furkatgofurov7
Copy link
Member

@Fedosin thanks for the PR. This is the post affect after we merged kubernetes/test-infra#29743.

To fix it in infra side itself I pushed kubernetes/test-infra#29804, PTAL.
More on the fix, here is slack thread: https://kubernetes.slack.com/archives/CCK68P2Q2/p1686743778996879

We can take this one too I guess, but if memory increasing helps it might not be needed, so holding this for now.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 14, 2023
@Fedosin
Copy link
Contributor Author

Fedosin commented Jun 14, 2023

@furkatgofurov7 ah, okay! good to know. Probably I can remove the timeout commit, but the other two are useful.

@furkatgofurov7
Copy link
Member

kubernetes/test-infra#29743 is merged and should fix both e2e main and make main jobs

/retest

@Fedosin
Copy link
Contributor Author

Fedosin commented Jun 14, 2023

@furkatgofurov7 seems like we have to increase timeout anyway: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api-operator/143/pull-cluster-api-operator-make-main/1668960250612420608

@furkatgofurov7
Copy link
Member

@furkatgofurov7 ah, okay! good to know. Probably I can remove the timeout commit, but the other two are useful.

@Fedosin timeout is still happening even though I bumped the memory for the job: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api-operator/143/pull-cluster-api-operator-make-main/1668960250612420608 which is strange, since in previous infra cluster where job was running it was fine. Maybe it takes more time to run the jobs in new eks prow cluster, and since it is passing here, let's not remove the timeout commit and take this in asap to unblock the CI.

@Fedosin
Copy link
Contributor Author

Fedosin commented Jun 14, 2023

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 14, 2023
Copy link
Contributor

@alexander-demicev alexander-demicev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexander-demicev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2023
@k8s-ci-robot k8s-ci-robot merged commit 507313f into kubernetes-sigs:main Jun 14, 2023
@furkatgofurov7
Copy link
Member

We need to cherry-pick this, since we will be hitting the same in release-0.3 branch (CI is running in both release-0.3 and main branches)

/cherry-pick release-0.3

@k8s-infra-cherrypick-robot

@furkatgofurov7: new pull request created: #164

In response to this:

We need to cherry-pick this, since we will be hitting the same in release-0.3 branch (CI is running in both release-0.3 and main branches)

/cherry-pick release-0.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants