Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cluster API: Update labels list #29421

Merged
merged 2 commits into from
May 11, 2023
Merged

Cluster API: Update labels list #29421

merged 2 commits into from
May 11, 2023

Conversation

killianmuldoon
Copy link
Contributor

@killianmuldoon killianmuldoon commented May 4, 2023 •
edited
Loading

Update the set of labels used by Cluster API.

@nawazkh
update labels as per google doc
4cdda6c 
- remove area/dependency since it is present is default section
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 4, 2023
@k8s-ci-robot k8s-ci-robot added area/label_sync Issues or PRs related to code in /label_sync sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels May 4, 2023
@killianmuldoon
Copy link
Contributor Author

/hold

This PR contains #29294

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 4, 2023
@killianmuldoon killianmuldoon force-pushed the add_area_labels_capi branch from 030c0c0 to efe4179 Compare May 4, 2023 10:15
killianmuldoon
killianmuldoon commented May 4, 2023
View reviewed changes
Copy link
Contributor Author

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbueringer This is the initial go at removing labels we don't use / want. Let me know what you think.

@killianmuldoon killianmuldoon force-pushed the add_area_labels_capi branch from efe4179 to f3d3c91 Compare May 4, 2023 11:04
@sbueringer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 4, 2023
@killianmuldoon
Copy link
Contributor Author

/hold cancel

Let's use this PR instead of #29294

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 4, 2023
@killianmuldoon killianmuldoon mentioned this pull request May 4, 2023
Closed
@killianmuldoon killianmuldoon changed the title Cluster API: Remove unneeded labels Cluster API: Update labels list May 4, 2023
@sbueringer
Copy link
Member

/approve

/assign @dims

@dims
Copy link
Member

dims commented May 4, 2023

/assign @aojea @BenTheElder

BenTheElder
BenTheElder reviewed May 11, 2023
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, killianmuldoon, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 11, 2023
@k8s-ci-robot k8s-ci-robot merged commit b59c6a3 into kubernetes:master May 11, 2023
@k8s-ci-robot
Copy link
Contributor

@killianmuldoon: Updated the label-config configmap in namespace test-pods at cluster test-infra-trusted using the following files:

  • key labels.yaml using file label_sync/labels.yaml

In response to this:

Update the set of labels used by Cluster API.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder left review comments

@mpherman2 mpherman2 Awaiting requested review from mpherman2

@stevekuznetsov stevekuznetsov Awaiting requested review from stevekuznetsov

Assignees

@dims dims

@BenTheElder BenTheElder

@sbueringer sbueringer

@aojea aojea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/label_sync Issues or PRs related to code in /label_sync cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@killianmuldoon @sbueringer @dims @k8s-ci-robot @BenTheElder @aojea @nawazkh