Update labels list for Cluster API #29294

nawazkh · 2023-04-12T21:33:07Z

This PR updates the list of labels to be added to issues and PRs at https://github.com/kubernetes-sigs/cluster-api.

Part of kubernetes-sigs/cluster-api#8263

killianmuldoon · 2023-04-12T22:09:52Z

label_sync/labels.yaml

@@ -1814,6 +1814,144 @@ repos:
        target: both
        prowPlugin: label
        addedBy: anyone
+      - color: 0052cc


I think there's a couple of labels to remove from above:

area/ux
area/artifacts
area/provider/docker
area/operator

and a couple of more. The list here should have the same number of items as the list in the doc.

Does that mean we drop labels like kind/proposal ?

No - This should be scoped to only area labels, let's not touch any of the labels with another prefix in the PR.

sbueringer · 2023-04-14T13:02:50Z

label_sync/labels.yaml

@@ -1814,6 +1814,144 @@ repos:
        target: both
        prowPlugin: label
        addedBy: anyone
+      - color: 0052cc
+        description: Issues or PRs related to CAPBK
+        name: area/kubeadm-bootstrap


I think this should be bootstrap-kubeadm and below control-plane-kubeadm

➜ k get provider -A NAMESPACE NAME AGE TYPE PROVIDER VERSION capd-system infrastructure-docker 37m InfrastructureProvider docker v1.4.99 capi-kubeadm-bootstrap-system bootstrap-kubeadm 43m BootstrapProvider kubeadm v1.4.99 capi-kubeadm-control-plane-system control-plane-kubeadm 43m ControlPlaneProvider kubeadm v1.4.99 capi-system cluster-api 43m CoreProvider cluster-api v1.4.99

I wonder if "provider" would be helpful as well (also for infrastructure-docker)

Maybe

area/provider/infrastructure-docker
area/provider/bootstrap-kubeadm
area/provider/control-plane-kubeadm
area/provider/core

(not sure if we don't like the provider segment)

or:

area/infrastructure-provider-docker
area/bootstrap-provider-kubeadm
area/control-plane-provider-kubeadm
area/core-provider

@killianmuldoon separate discussion. Maybe we should start a discussion around moving the core provider stuff into a core folder. This would make the structure of our repository a lot easier
(we can keep the core APIs where they are if folks are concerned about moving them, although all the core APIs which are not already in the top-level api folder will have to move sooner or later anyway)

Related, maybe we should re-structure a bunch more stuff in our repo.

On changing the label naming here - to add "provider" either as a path prefix or elsewhere - I don't think it really helps or hinders. Just happy to pick any form and stick to it.

Agree with moving stuff into a core folder, but this probably isn't the place to have a good discussion on it 😄

I would prefer if we have provider in the label name. If we don't want an additional segment we can use the form without, otherwise I would pick the ones in this format: "area/provider/infrastructure-docker"

Definitely just wanted to bring up the topic :)

Added area/provider/core
updated labels as

area/provider/infrastructure-docker area/provider/bootstrap-kubeadm area/provider/control-plane-kubeadm

label_sync/labels.yaml

sbueringer · 2023-04-14T13:14:49Z

label_sync/labels.yaml

+        target: both
+        prowPlugin: label
+        addedBy: anyone
+      - color: 0052cc


Similar to the comment in the doc. Seems like now we have clusterclass and topology

Yeah - I'm happy to pick one or the other. Maybe ClusterClass as it's clearer for release notes?

I think ClusterClass is more expressive

topology could be so much more or something very different as ClusterClass

Updated to using clusterclass. Shall I be updating to topology instead?

No updating to clusterclass is fine. I just meant that topology is too generic.

sbueringer · 2023-04-14T13:15:32Z

label_sync/labels.yaml

+        addedBy: anyone
+      - color: 0052cc
+        description: Issues or PRs related to devtools
+        name: area/devtools


Didn't find it in the doc. What do we see as devtools, all the tilt stuff?

tilt stuff, any other helper scripts etc. I think.

Maybe would be good to give a hint in the label description. Although I'm a bit nitpicky here

Kept it as is for now unless you want me to remove it.

It's fine let's keep it as is

sbueringer · 2023-04-26T17:46:35Z

/hold

I want to run the label sync with dry-run locally before we merge this PR.

I don't want to risk unintended side effects

sbueringer · 2023-04-26T17:49:44Z

label_sync/labels.yaml

-      - color: c7def8
-        description: Issues or PRs related to proposals.
-        name: kind/proposal
-        target: both
-        prowPlugin: label
-        addedBy: anyone
-      - color: f6c5d8
-        description: Issues or PRs that need to be closed before the next CAPI release
-        name: kind/release-blocking
-        target: both
-        prowPlugin: label
-        addedBy: approvers
      - color: 0052cc


I think we don't want to drop those

killianmuldoon · 2023-04-27T13:55:46Z

Hey @nawazkh - just did a round of review on this with @sbueringer. We found out there's a couple of gotchas with removing labels as we're not sure of the syncing between this list and the CAPI repo. We also did another round on the label google document and created a new list - https://docs.google.com/document/d/1PWUZsoO-4Un4FHszEeMDCF_007ic6uA0WRj-crMhB3A/edit#

For this PR I think the best route forward is:

don't drop any labels in this PR
Add any labels from the google doc which don't exist in this list in this PR

Then in a follow-up we can remove the labels we don't want. How does that sound to you?

nawazkh · 2023-04-28T06:30:15Z

For this PR I think the best route forward is:

don't drop any labels in this PR

Add any labels from the google doc which don't exist in this list in this PR

Sounds good to me!

nawazkh · 2023-05-02T05:58:27Z

/test pull-test-infra-verify-lint

nawazkh · 2023-05-02T06:55:01Z

Removed area/dependency as pull-test-infra-verify-lint was failing with the error duplicate label area/dependency at kubernetes-sigs/cluster-api.area/dependency and default.area/dependency.
area/dependency is already part of default section.

killianmuldoon

Looks good to me pending running the make target.

@CecileRobertMichon in case you want to take another look as there's been a couple of changes since you initially reviewed the doc.

@sbueringer also ready for your review for the added labels.

- remove area/dependency since it is present is default section

sbueringer · 2023-05-03T18:37:59Z

Thx!

looks good

/lgtm
/approve
/hold cancel

Please feel free to continue the reviews and we can do a follow-up PR if necessary

k8s-ci-robot · 2023-05-03T18:38:56Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nawazkh, sbueringer
Once this PR has been reviewed and has the lgtm label, please assign spiffxp for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

label_sync/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sbueringer · 2023-05-03T18:45:01Z

/assign @cblecker

killianmuldoon · 2023-05-04T11:28:23Z

/close

In favor of #29421

k8s-ci-robot · 2023-05-04T11:28:28Z

@killianmuldoon: Closed this PR.

In response to this:

/close

In favor of #29421

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 12, 2023

k8s-ci-robot requested review from aojea, cblecker and mpherman2 April 12, 2023 21:33

k8s-ci-robot added area/label_sync Issues or PRs related to code in /label_sync sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Apr 12, 2023

nawazkh mentioned this pull request Apr 12, 2023

🌱 Add and update Owners file to the repo kubernetes-sigs/cluster-api#8519

Closed

killianmuldoon reviewed Apr 12, 2023

View reviewed changes

sbueringer reviewed Apr 14, 2023

View reviewed changes

nawazkh force-pushed the add_area_labels_capi branch from 3d20672 to de0dbec Compare April 17, 2023 22:44

nawazkh requested review from sbueringer and killianmuldoon April 17, 2023 22:47

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 26, 2023

sbueringer reviewed Apr 26, 2023

View reviewed changes

nawazkh force-pushed the add_area_labels_capi branch from de0dbec to c758193 Compare April 28, 2023 07:31

nawazkh force-pushed the add_area_labels_capi branch 2 times, most recently from b414217 to 078a9f1 Compare May 2, 2023 06:52

killianmuldoon reviewed May 3, 2023

View reviewed changes

update labels as per google doc

4cdda6c

- remove area/dependency since it is present is default section

nawazkh force-pushed the add_area_labels_capi branch from 078a9f1 to 4cdda6c Compare May 3, 2023 17:01

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 3, 2023

k8s-ci-robot assigned sbueringer May 3, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2023

k8s-ci-robot assigned cblecker May 3, 2023

killianmuldoon mentioned this pull request May 4, 2023

Cluster API: Update labels list #29421

Merged

k8s-ci-robot closed this May 4, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update labels list for Cluster API #29294

Update labels list for Cluster API #29294

nawazkh commented Apr 12, 2023 •

edited

Loading

killianmuldoon Apr 12, 2023

nawazkh Apr 17, 2023

killianmuldoon Apr 18, 2023

sbueringer Apr 14, 2023

sbueringer Apr 14, 2023

killianmuldoon Apr 14, 2023 •

edited

Loading

sbueringer Apr 14, 2023

nawazkh Apr 17, 2023

sbueringer Apr 14, 2023

killianmuldoon Apr 14, 2023

sbueringer Apr 14, 2023

nawazkh Apr 17, 2023

sbueringer Apr 26, 2023 •

edited

Loading

sbueringer Apr 14, 2023

killianmuldoon Apr 14, 2023

sbueringer Apr 14, 2023 •

edited

Loading

nawazkh Apr 17, 2023

sbueringer Apr 26, 2023

sbueringer commented Apr 26, 2023 •

edited

Loading

sbueringer Apr 26, 2023

killianmuldoon commented Apr 27, 2023

nawazkh commented Apr 28, 2023

nawazkh commented May 2, 2023

nawazkh commented May 2, 2023

killianmuldoon left a comment

sbueringer commented May 3, 2023

k8s-ci-robot commented May 3, 2023

sbueringer commented May 3, 2023

killianmuldoon commented May 4, 2023

k8s-ci-robot commented May 4, 2023

Update labels list for Cluster API #29294

Update labels list for Cluster API #29294

Conversation

nawazkh commented Apr 12, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

killianmuldoon Apr 14, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sbueringer Apr 26, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sbueringer Apr 14, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sbueringer commented Apr 26, 2023 • edited Loading

Choose a reason for hiding this comment

killianmuldoon commented Apr 27, 2023

nawazkh commented Apr 28, 2023

nawazkh commented May 2, 2023

nawazkh commented May 2, 2023

killianmuldoon left a comment

Choose a reason for hiding this comment

sbueringer commented May 3, 2023

k8s-ci-robot commented May 3, 2023

sbueringer commented May 3, 2023

killianmuldoon commented May 4, 2023

k8s-ci-robot commented May 4, 2023

nawazkh commented Apr 12, 2023 •

edited

Loading

killianmuldoon Apr 14, 2023 •

edited

Loading

sbueringer Apr 26, 2023 •

edited

Loading

sbueringer Apr 14, 2023 •

edited

Loading

sbueringer commented Apr 26, 2023 •

edited

Loading