Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add S3 sync jobs #27344

Merged
merged 1 commit into from
Sep 7, 2022
Merged

Add S3 sync jobs #27344

merged 1 commit into from
Sep 7, 2022

Conversation

upodroid
Copy link
Member

@upodroid upodroid commented Sep 1, 2022

Fixes: kubernetes/k8s.io#3807

Adding a Prow Job to write blobs to S3.

The script isn't ready yet so for now it is just going to authenticate to AWS to test that it works. @BobyMCbobs will raise a PR later with the scripts.

AWS Infra Change: cncf-infra/aws-infra#15
Prow Infra Change: kubernetes/k8s.io#4170
We will be using an AWS service to replicate the blobs from the primary bucket to all the other S3 buckets. kubernetes/k8s.io#4118

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Sep 1, 2022
@upodroid
Copy link
Member Author

upodroid commented Sep 1, 2022

/cc @ameukam

@k8s-ci-robot k8s-ci-robot requested a review from ameukam September 1, 2022 21:51
@BobyMCbobs
Copy link
Member

I will convert this one into a sync between the US GCS bucket->s3 us-east-2 for registry.k8s.io.
Might create a periodic per region for syncing s3->s3.

@BobyMCbobs
Copy link
Member

BobyMCbobs commented Sep 5, 2022

Looks like we'll need a custom container image for use in the job.
The other dependency we need, besides awscli is rclone.

Unsure what the policy on building such images is, whether to use existing external images as base (such as amazon/aws-cli) and pin it and use a differently tagged version, or to start from scratch and to bring in awscli via python-pip

@dims
Copy link
Member

dims commented Sep 5, 2022

/approve
/lgtm

Looks like we will be iterating. The second variation (awscli using python-pip) will probably give us better control over what we need.

/hold feel free to remove hold when ready

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 5, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2022
@upodroid
Copy link
Member Author

upodroid commented Sep 6, 2022

This can be merged once kubernetes/k8s.io#4185 has been merged and the IAM roles on the prow bucket has been added.

@upodroid
Copy link
Member Author

upodroid commented Sep 7, 2022

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 7, 2022
@upodroid
Copy link
Member Author

upodroid commented Sep 7, 2022

/retest-required

@k8s-ci-robot k8s-ci-robot merged commit b63e567 into kubernetes:master Sep 7, 2022
@k8s-ci-robot
Copy link
Contributor

@upodroid: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key releng-gcs-to-aws-sync.yaml using file config/jobs/kubernetes/sig-k8s-infra/trusted/releng/releng-gcs-to-aws-sync.yaml

In response to this:

Fixes: kubernetes/k8s.io#3807

Adding a Prow Job to write blobs to S3.

The script isn't ready yet so for now it is just going to authenticate to AWS to test that it works. @BobyMCbobs will raise a PR later with the scripts.

AWS Infra Change: cncf-infra/aws-infra#15
Prow Infra Change: kubernetes/k8s.io#4170
We will be using an AWS service to replicate the blobs from the primary bucket to all the other S3 buckets. kubernetes/k8s.io#4118

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider using Kubernetes Service Accounts to authenticate with AWS
4 participants