Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add S3 sync GCP service accounts #4185

Closed
wants to merge 1 commit into from

Conversation

upodroid
Copy link
Member

@upodroid upodroid commented Sep 6, 2022

Part of #4170

Can someone assign the Storage Object Creator role on the prow bucket for this account?

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/infra Infrastructure management, infrastructure design, code in infra/ area/prow Setting up or working with prow in general, prow.k8s.io, prow build clusters area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ labels Sep 6, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: upodroid
Once this PR has been reviewed and has the lgtm label, please assign stevekuznetsov for approval by writing /assign @stevekuznetsov in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Sep 6, 2022
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 6, 2022
@listx
Copy link
Contributor

listx commented Sep 6, 2022

Part of #4170

Can someone assign the Storage Object Creator role on the prow bucket for this account?

I don't have enough context to understand what needs to be done here, not to mention whether I even have permissions to do so.

@ameukam
Copy link
Member

ameukam commented Sep 7, 2022

Part of #4170

Can someone assign the Storage Object Creator role on the prow bucket for this account?

which prow bucket ? AFAIK we don't need specific permissions to push the logs for all the prowjobs. what's particular about this service account ?

/uncc @listx @cjwagner

@upodroid
Copy link
Member Author

upodroid commented Sep 7, 2022

Actually, ignore my comment and we don't need this PR.

https://prow.k8s.io/prowjob?prowjob=12723dcb-2e9e-11ed-8857-d61b7b5f68bf I assumed k8s' prow was using Workload Identity for writing to gs://kubernetes-jenkins but it seems we are still using service account keys (spec.decoration_configs.gcs_credentials_secret is set)

/close

@k8s-ci-robot
Copy link
Contributor

@upodroid: Closed this PR.

In response to this:

Actually, ignore my comment and we don't need this PR.

https://prow.k8s.io/prowjob?prowjob=12723dcb-2e9e-11ed-8857-d61b7b5f68bf I assumed k8s' prow was using Workload Identity for writing to gs://kubernetes-jenkins but it seems we are still using service account keys (spec.decoration_configs.gcs_credentials_secret is set)

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/infra Infrastructure management, infrastructure design, code in infra/ area/prow Setting up or working with prow in general, prow.k8s.io, prow build clusters area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants