Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WS2022 capz extension job #26484

Merged
merged 1 commit into from
Jun 6, 2022

Conversation

jsturtevant
Copy link
Contributor

We needed more flexibility with templates and ability to install additional tooling for things like gmsa so we've developed a new script for Windows e2e using capz. This script is a WIP so have using a few branches to run the job until it stable. The script is running locally but we may need to adjust things in prow env.

This relies on kubernetes-sigs/windows-testing#322 and kubernetes-sigs/cluster-api-provider-azure#2345

/assign @marosset
/sig windows

@k8s-ci-robot k8s-ci-robot added sig/windows Categorizes an issue or PR as relevant to SIG Windows. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config labels Jun 4, 2022
@k8s-ci-robot k8s-ci-robot requested a review from andyzhangx June 4, 2022 00:11
@k8s-ci-robot k8s-ci-robot requested a review from ddebroy June 4, 2022 00:11
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Jun 4, 2022
@jsturtevant
Copy link
Contributor Author

/hold
going to make this a pre-submit against the windows-testing repo so can iterate on the script

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 5, 2022
@jsturtevant jsturtevant force-pushed the ws-2022-capz-extension branch 2 times, most recently from 7ae1fd5 to 13fe186 Compare June 6, 2022 16:25
@jsturtevant jsturtevant force-pushed the ws-2022-capz-extension branch from 13fe186 to 0bbb2ab Compare June 6, 2022 16:26
@jsturtevant
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 6, 2022
preset-kind-volume-mounts: "true"
preset-azure-cred-only: "true"
preset-windows-private-registry-cred: "true"
preset-capz-windows-common-main: "true"
Copy link
Contributor

@marosset marosset Jun 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be preset-capz-windows-common-pull instead of preset-capz-windows-common-main?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't a presubmit against k/k. We are using k/k CI builds so it's more accurate to be using the CI preset-capz-windows-common-main I think.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it

@marosset
Copy link
Contributor

marosset commented Jun 6, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 6, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsturtevant, marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit bdc05a2 into kubernetes:master Jun 6, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jun 6, 2022
@k8s-ci-robot
Copy link
Contributor

@jsturtevant: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key release-master-windows-presubmits.yaml using file config/jobs/kubernetes-sigs/sig-windows/release-master-windows-presubmits.yaml

In response to this:

We needed more flexibility with templates and ability to install additional tooling for things like gmsa so we've developed a new script for Windows e2e using capz. This script is a WIP so have using a few branches to run the job until it stable. The script is running locally but we may need to adjust things in prow env.

This relies on kubernetes-sigs/windows-testing#322 and kubernetes-sigs/cluster-api-provider-azure#2345

/assign @marosset
/sig windows

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants