-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WS2022 capz extension job #26484
WS2022 capz extension job #26484
Conversation
/hold |
7ae1fd5
to
13fe186
Compare
13fe186
to
0bbb2ab
Compare
/hold cancel |
preset-kind-volume-mounts: "true" | ||
preset-azure-cred-only: "true" | ||
preset-windows-private-registry-cred: "true" | ||
preset-capz-windows-common-main: "true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be preset-capz-windows-common-pull
instead of preset-capz-windows-common-main
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't a presubmit against k/k. We are using k/k CI builds so it's more accurate to be using the CI preset-capz-windows-common-main
I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsturtevant, marosset The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jsturtevant: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
We needed more flexibility with templates and ability to install additional tooling for things like gmsa so we've developed a new script for Windows e2e using capz. This script is a WIP so have using a few branches to run the job until it stable. The script is running locally but we may need to adjust things in prow env.
This relies on kubernetes-sigs/windows-testing#322 and kubernetes-sigs/cluster-api-provider-azure#2345
/assign @marosset
/sig windows