Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sig-windows custom E2E script and template for cluster api provider azure #322

Merged
merged 1 commit into from
Jun 17, 2022
Merged

sig-windows custom E2E script and template for cluster api provider azure #322

merged 1 commit into from
Jun 17, 2022

Conversation

jsturtevant
Copy link
Contributor

We needed more flexibility with templates and ability to install additional tooling for things like gmsa so we've developed a new script for Windows e2e using capz. This script is a WIP so have using a few branches to run the job until it stable. This script does work locally.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 4, 2022
@k8s-ci-robot k8s-ci-robot requested review from chewong and ddebroy June 4, 2022 00:08
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 4, 2022
@jsturtevant jsturtevant mentioned this pull request Jun 4, 2022
Merged
@jsturtevant
Copy link
Contributor Author

/hold
until we get some validation in prow env

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 4, 2022
@jsturtevant
Copy link
Contributor Author

/test pull-e2e-capz-containerd-windows-2022-extension

@jsturtevant
Copy link
Contributor Author

/test pull-e2e-capz-containerd-windows-2022-extension

@jsturtevant
Copy link
Contributor Author

/test pull-e2e-capz-containerd-windows-2022-extension

@jsturtevant
Copy link
Contributor Author

/test pull-e2e-capz-containerd-windows-2022-extension

@jsturtevant jsturtevant force-pushed the windows-capz-e2e branch 2 times, most recently from 91a5c73 to 7650dd3 Compare June 7, 2022 14:52
@jsturtevant
Copy link
Contributor Author

/test pull-e2e-capz-containerd-windows-2022-extension

@jsturtevant
Copy link
Contributor Author

/test pull-e2e-capz-containerd-windows-2022-extension

1 similar comment
@jsturtevant
Copy link
Contributor Author

/test pull-e2e-capz-containerd-windows-2022-extension

@jsturtevant jsturtevant force-pushed the windows-capz-e2e branch 2 times, most recently from c9f060b to c0f5053 Compare June 8, 2022 22:09
@jsturtevant
Copy link
Contributor Author

/assign @marosset

@jsturtevant jsturtevant changed the title First pass at custom script and template for E2E sig-windows custom E2e script and template for cluster api provider azure Jun 9, 2022
@jsturtevant jsturtevant changed the title sig-windows custom E2e script and template for cluster api provider azure sig-windows custom E2E script and template for cluster api provider azure Jun 9, 2022
marosset
marosset reviewed Jun 10, 2022
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
@marosset
Copy link
Contributor

@jsturtevant can you split the image repo updates into a separate commit or PR?
Those changes have the potential to impact existing jobs.

@marosset
Copy link
Contributor

Should we rename the azure folder to capz (or rename the templates folder to capz-templates?
The aks-engine templates in this repo work on azure too.

Can you also add a README that at a minumum points to the az-capi repo and possibly capz repo/playbook so people can understand what the env vars do.

@jsturtevant
Copy link
Contributor Author

can you split the image repo updates into a separate commit or PR?

yes, will split the changes. Got a little carried away :-)

Should we rename the azure folder to capz (or rename the templates folder to capz-templates?
The aks-engine templates in this repo work on azure too.
Can you also add a README that at a minumum points to the az-capi repo and possibly capz repo/playbook so people can understand what the env vars do.

capz folder makes sense, wasn't sure what to call it. A Readme makes alot of sense 👍

@jsturtevant jsturtevant force-pushed the windows-capz-e2e branch 2 times, most recently from deb2d79 to 725b4c4 Compare June 13, 2022 17:29
@jsturtevant
Copy link
Contributor Author

/test pull-e2e-capz-containerd-windows-2022-extension

@jsturtevant jsturtevant mentioned this pull request Jun 13, 2022
Merged
@jsturtevant
Copy link
Contributor Author

/test pull-e2e-capz-containerd-windows-2022-extension

@jsturtevant
Copy link
Contributor Author

/test pull-e2e-capz-containerd-windows-2022-extension

marosset
marosset approved these changes Jun 13, 2022
View reviewed changes
Copy link
Contributor

@marosset marosset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks for incorporating my feedback.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 13, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsturtevant, marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jsturtevant,marosset]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jsturtevant
Copy link
Contributor Author

hcsshim is triggering windows defender to clean it up. Going to update the containerd version in our jobs

 E0613 22:01:58.570438    1408 remote_runtime.go:201] "RunPodSandbox from runtime service failed" err=<
	rpc error: code = Unknown desc = failed to create containerd task: failed to start shim: start failed: fork/exec C:\Program Files\containerd\containerd-shim-runhcs-v1.exe: Operation did not complete successfully because the file contains a virus or potentially unwanted software.
	: exit status 1: unknown

@jsturtevant
Copy link
Contributor Author

kubernetes/test-infra#26570

@jsturtevant
Copy link
Contributor Author

/test pull-e2e-capz-containerd-windows-2022-extension

@jsturtevant
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 17, 2022
@k8s-ci-robot k8s-ci-robot merged commit 12be22e into kubernetes-sigs:master Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marosset marosset marosset approved these changes

@chewong chewong Awaiting requested review from chewong

@ddebroy ddebroy Awaiting requested review from ddebroy

Assignees

@marosset marosset

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsturtevant @marosset @k8s-ci-robot