-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azure: use capz 1.0 release branch for in-tree azure tests #25201
azure: use capz 1.0 release branch for in-tree azure tests #25201
Conversation
@@ -789,6 +789,6 @@ periodics: | |||
memory: "4Gi" | |||
annotations: | |||
testgrid-dashboards: provider-azure-master-signal | |||
testgrid-tab-name: capz-latest-release-azure-disk-vmss | |||
testgrid-tab-name: capz-release-azure-disk-vmss |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing the name here will lose the history but other wise will be fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, jackfrancis, jsturtevant The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jackfrancis: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sorry for the thrashing today. This prior PR pinned in-tree cloud-provider-azure tests to the release-1.1 branch of capz:
#25193
Initial test signal after change suggests that these tests are still not happy against capz @
release-1.1
:https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/107981/pull-kubernetes-e2e-capz-conformance/1491515486653911040
The original reason for all of these changes was a breakage in the capz commit @
v1.0.1
. For example:https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/107981/pull-kubernetes-e2e-capz-conformance/1491294976963776512
The root cause of the above failures is well-known (it's due to a cert-manager regression in versions of cluster-api prior to
v1.0.4
). Because (1) we have a prior history of success running these in-tree cloud-provider azure tests against a capz v1.0 version and (2) because therelease-1.0
branch of capz has the required, new version of cluster-api built into its CI and cluster definitions (see kubernetes-sigs/cluster-api-provider-azure#2038), lets pin these test-infra jobs to therelease-1.0
branch instead ofrelease-1.1
.