Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure: use capz 1.0 release branch for in-tree azure tests #25201

Conversation

jackfrancis
Copy link
Contributor

Sorry for the thrashing today. This prior PR pinned in-tree cloud-provider-azure tests to the release-1.1 branch of capz:

#25193

Initial test signal after change suggests that these tests are still not happy against capz @ release-1.1:

https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/107981/pull-kubernetes-e2e-capz-conformance/1491515486653911040

The original reason for all of these changes was a breakage in the capz commit @ v1.0.1. For example:

https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/107981/pull-kubernetes-e2e-capz-conformance/1491294976963776512

The root cause of the above failures is well-known (it's due to a cert-manager regression in versions of cluster-api prior to v1.0.4). Because (1) we have a prior history of success running these in-tree cloud-provider azure tests against a capz v1.0 version and (2) because the release-1.0 branch of capz has the required, new version of cluster-api built into its CI and cluster definitions (see kubernetes-sigs/cluster-api-provider-azure#2038), lets pin these test-infra jobs to the release-1.0 branch instead of release-1.1.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs area/provider/azure Issues or PRs related to azure provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 10, 2022
@@ -789,6 +789,6 @@ periodics:
memory: "4Gi"
annotations:
testgrid-dashboards: provider-azure-master-signal
testgrid-tab-name: capz-latest-release-azure-disk-vmss
testgrid-tab-name: capz-release-azure-disk-vmss
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the name here will lose the history but other wise will be fine

Copy link
Contributor

@jsturtevant jsturtevant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 10, 2022
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, jackfrancis, jsturtevant

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2022
@k8s-ci-robot k8s-ci-robot merged commit d5a7fcd into kubernetes:master Feb 10, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Feb 10, 2022
@k8s-ci-robot
Copy link
Contributor

@jackfrancis: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key release-1.20.yaml using file config/jobs/kubernetes/sig-cloud-provider/azure/release-1.20.yaml
  • key release-1.21.yaml using file config/jobs/kubernetes/sig-cloud-provider/azure/release-1.21.yaml
  • key release-1.22.yaml using file config/jobs/kubernetes/sig-cloud-provider/azure/release-1.22.yaml
  • key release-1.23.yaml using file config/jobs/kubernetes/sig-cloud-provider/azure/release-1.23.yaml
  • key release-master.yaml using file config/jobs/kubernetes/sig-cloud-provider/azure/release-master.yaml

In response to this:

Sorry for the thrashing today. This prior PR pinned in-tree cloud-provider-azure tests to the release-1.1 branch of capz:

#25193

Initial test signal after change suggests that these tests are still not happy against capz @ release-1.1:

https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/107981/pull-kubernetes-e2e-capz-conformance/1491515486653911040

The original reason for all of these changes was a breakage in the capz commit @ v1.0.1. For example:

https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/107981/pull-kubernetes-e2e-capz-conformance/1491294976963776512

The root cause of the above failures is well-known (it's due to a cert-manager regression in versions of cluster-api prior to v1.0.4). Because (1) we have a prior history of success running these in-tree cloud-provider azure tests against a capz v1.0 version and (2) because the release-1.0 branch of capz has the required, new version of cluster-api built into its CI and cluster definitions (see kubernetes-sigs/cluster-api-provider-azure#2038), lets pin these test-infra jobs to the release-1.0 branch instead of release-1.1.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jackfrancis jackfrancis deleted the in-tree-cloud-provider-azure-capz-1.0 branch February 10, 2022 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants