Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure: use correct capz release branches for cloud-provider-azure tests #25193

Merged

Conversation

jackfrancis
Copy link
Contributor

This PR modifies the cloud-provider-azure test jobs in two ways:

  1. Periodic release jobs now run against the capz "latest release" branch (instead of main). This is to get regular signal before a cloud-provider-azure release that there is something unhealthy in the cloud-provider-azure<-->capz dependency at the intersection that will block the next cloud-provider-azure release. By fixing these issues before a release, we will do a better job of preventing blocking release issues.
  2. Adds a new set of cloud-provider-azure tests that use the "latest" capz release (the same release branch that the cloud-provider-azure release tests depend upon). The purpose of these jobs is to anticipate breakage in cloud-provider-azure + capz before the commits are cherry-picked into the cloud-provider-azure release branches. As above, this will give more advance signal of issues, and will help to keep cloud-provider-azure release branch commit histories cleaner.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 9, 2022
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs area/provider/azure Issues or PRs related to azure provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 9, 2022
@jsturtevant
Copy link
Contributor

@jackfrancis jackfrancis force-pushed the capz-release-1.1-rationalization branch from 4c6e1fb to 9c74b0f Compare February 9, 2022 22:16
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 9, 2022
@jackfrancis jackfrancis force-pushed the capz-release-1.1-rationalization branch from 9c74b0f to 062b55c Compare February 9, 2022 22:18
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 10, 2022
@jackfrancis jackfrancis force-pushed the capz-release-1.1-rationalization branch from 062b55c to ed0d55d Compare February 10, 2022 00:22
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 10, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 10, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chewong, jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 45d81fc into kubernetes:master Feb 10, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Feb 10, 2022
@k8s-ci-robot
Copy link
Contributor

@jackfrancis: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key release-1.20.yaml using file config/jobs/kubernetes/sig-cloud-provider/azure/release-1.20.yaml
  • key release-1.21.yaml using file config/jobs/kubernetes/sig-cloud-provider/azure/release-1.21.yaml
  • key release-1.22.yaml using file config/jobs/kubernetes/sig-cloud-provider/azure/release-1.22.yaml
  • key release-1.23.yaml using file config/jobs/kubernetes/sig-cloud-provider/azure/release-1.23.yaml
  • key release-master.yaml using file config/jobs/kubernetes/sig-cloud-provider/azure/release-master.yaml

In response to this:

This PR modifies the cloud-provider-azure test jobs in two ways:

  1. Periodic release jobs now run against the capz "latest release" branch (instead of main). This is to get regular signal before a cloud-provider-azure release that there is something unhealthy in the cloud-provider-azure<-->capz dependency at the intersection that will block the next cloud-provider-azure release. By fixing these issues before a release, we will do a better job of preventing blocking release issues.
  2. Adds a new set of cloud-provider-azure tests that use the "latest" capz release (the same release branch that the cloud-provider-azure release tests depend upon). The purpose of these jobs is to anticipate breakage in cloud-provider-azure + capz before the commits are cherry-picked into the cloud-provider-azure release branches. As above, this will give more advance signal of issues, and will help to keep cloud-provider-azure release branch commit histories cleaner.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jackfrancis jackfrancis deleted the capz-release-1.1-rationalization branch February 10, 2022 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants