Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove periodic-enhancements-unfreeze job #22488

Merged
merged 1 commit into from
Jun 9, 2021

Conversation

mrbobbytables
Copy link
Member

Enhancement tracking issues should not rot out, they should be closed when their feature has graduated or removed for another reason.

/cc @BenTheElder @kikisdeliveryservice

Enhancement tracking issues should not rot out, they should be closed when their feature has graduated or removed for another reason.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 9, 2021
Copy link
Member

@kikisdeliveryservice kikisdeliveryservice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree on this. Closed issues need to have specific meaning/state, auto-closing reduces visibility and can cause loss of kep status clarity. Allowing authors to freeze would be useful.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 9, 2021
@justaugustus
Copy link
Member

Agreed with the current state assessment from @kikisdeliveryservice + @mrbobbytables, but linking #8637 for historical context:

Based on the current parameters for fejta-bot checks, issues will be closed after 90 days, after moving through various lifecycle/* phases.

The lifecycle/frozen label was introduced to ensure critical issues remain open. However, because Features issues should be reviewed and updated every release cycle (~90 days), I'd like to discourage / disable the use of the lifecycle/frozen label via automation.

This PR prevents issues in k/features from being marked as lifecycle/frozen

Slack convo: https://kubernetes.slack.com/archives/C09QZ4DQB/p1531154081000419

It's wonderful that enhancements are flowing in a way that this is no longer required!

xref current Slack convo: https://kubernetes.slack.com/archives/C1L57L91V/p1623189852047200
cc: @sftim @kubernetes/enhancements

/assign @BenTheElder @dims @fejta
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, justaugustus, kikisdeliveryservice, mrbobbytables

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2021
@k8s-ci-robot k8s-ci-robot merged commit 5d8fee9 into kubernetes:master Jun 9, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jun 9, 2021
@k8s-ci-robot
Copy link
Contributor

@mrbobbytables: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key fejta-bot-periodics.yaml using file config/jobs/kubernetes/test-infra/fejta-bot-periodics.yaml

In response to this:

Enhancement tracking issues should not rot out, they should be closed when their feature has graduated or removed for another reason.

/cc @BenTheElder @kikisdeliveryservice

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants