Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repurpose fejta-bot + k8s-ci-robot to ping-bot #5473

Closed
abitrolly opened this issue Jan 27, 2021 · 14 comments
Closed

Repurpose fejta-bot + k8s-ci-robot to ping-bot #5473

abitrolly opened this issue Jan 27, 2021 · 14 comments
Labels
sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience.

Comments

@abitrolly
Copy link

What should be cleaned up or changed:

The lifecycle messages for non-solved issues are getting annoying. The message below has erupted from this thread kubernetes/kubernetes#54923 (comment)

I don't get the point of this bot.

The bot will keep trying to close this issue, but I suspect as soon as it succeeds another Issue will take its place: There is clearly an Interest in this issue, so I'll keep "refreshing" this issue until someone tells me to stop.

I don't like doing this, since it just adds noise to this discussion, and will spam everyone observing or participating in this issue.
Is there a way around this eternal back-and-forth?

A solution to reduce the noise was to implement a ping instead of auto-close.

(btw totally agree, a "ping-bot" should be fine for the same use case and it wouldn't close it mistakenly)

An even better solution could be to have a process linked to ping-bot message. The process that allows to construct a heads-up or evaluate the importance and priority of the issue. Get updates on what's happening with it - is the issue forgotten, is somebody working on it, what is the next roadblock, is there some decomposition or decision needed to deal with the roadblock..

@immanuelfodor
Copy link

"totally agree" quote guy here, thanks for opening a separate issue for this 😃

@BenTheElder
Copy link
Member

you can prevent cleanup and comments by commenting /lifecycle frozen. otherwise the intention (not mine) was to age out issues nobody is interacting with that have not explicitly been marked as "nobody is working on this but we need to keep it tracked"

workflow changes must go through @kubernetes/sig-contributor-experience
/sig contributor-experience

this should be migrated to github.com/kubernetes/community, if contributor experience agrees to changes, we can change the bot.

@mrbobbytables mrbobbytables transferred this issue from kubernetes/test-infra Feb 6, 2021
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Feb 6, 2021
@BenTheElder
Copy link
Member

thanks @mrbobbytables, xref: kubernetes/test-infra#20767
/sig contributor-experience

@k8s-ci-robot k8s-ci-robot added sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 6, 2021
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 7, 2021
@immanuelfodor
Copy link

A few weeks ago, I got the feedback that I should never use frozen on tickets, so I'm confused, and still support the ping alternative.

@immanuelfodor
Copy link

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 7, 2021
@abitrolly
Copy link
Author

The ping-bot could also collect public stats about most missing issues, most annoying notifications and the longest waited features.

@BenTheElder
Copy link
Member

A few weeks ago, I got the feedback that I should never use frozen on tickets, so I'm confused, and still support the ping alternative.

Sorry I'm just making it back through my own notifications (far too many...), can you share where you received this?
I know the enhancements repo had something like this, and I raised my concerns about that and we got this disabled there, but I'm not aware of this anywhere else and I don't agree, otherwise we would not have the ability to freeze issues.

@kubernetes/sig-contributor-experience PTAL

also regarding the bot naming: kubernetes/test-infra#12296

@immanuelfodor
Copy link

kubernetes/enhancements#361 (comment)

kubernetes/enhancements#362 (comment)

@BenTheElder
Copy link
Member

Ok yeah, I strongly disagree with this and after discussion with SIG contributor experience in their slack about a week ago we got it disabled, you should not receive those comments again.

kubernetes/test-infra#22488 disabled them.

@BenTheElder
Copy link
Member

I've just re-frozen those issues.

If there are any more in kubernetes/enhancements the same applies.

In particular there is no good reason for automation to pre-emptively close tracked enhancements that already have a merged KEP document but aren't GA / complete yet. I'm not sure I agree with the lifecycle system in general, but that stuck out as particularly pointless / unhelpful, so I was able to actually get movement on that part and it shouldn't happen anymore.

@spiffxp
Copy link
Member

spiffxp commented Jul 22, 2021

/close
The reasons fejta-bot is a separate account is because:

  • it is unprivileged, as a demonstration of what any contributor could do with automation
  • it avoids exhausting the GitHub API token limit used by k8s-ci-robot
  • it was setup by someone named fejta

There is an issue to use k8s-triage-robot instead kubernetes/test-infra#12296

@k8s-ci-robot
Copy link
Contributor

@spiffxp: Closing this issue.

In response to this:

/close
The reasons fejta-bot is a separate account is because:

  • it is unprivileged, as a demonstration of what any contributor could do with automation
  • it avoids exhausting the GitHub API token limit used by k8s-ci-robot
  • it was setup by someone named fejta

There is an issue to use k8s-triage-robot instead kubernetes/test-infra#12296

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BenTheElder
Copy link
Member

and a more general issue regarding auto-closing (which is not the only thing the bot does) kubernetes/kubernetes#103151

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience.
Projects
None yet
Development

No branches or pull requests

6 participants