Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

images/builder: update to cloud-sdk 343.0 #22464

Merged

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Jun 7, 2021

I think the version of gcloud builds submit at 258.0.0 doesn't understand options.machineType which is breaking the job introduced in #22458 which is supposed to build kubernetes/k8s.io#2134

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 7, 2021
@k8s-ci-robot k8s-ci-robot requested review from chaodaiG and chases2 June 7, 2021 21:34
@k8s-ci-robot k8s-ci-robot added area/images sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 7, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Jun 7, 2021

/cc @dims @ameukam

Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 7, 2021
@ameukam
Copy link
Member

ameukam commented Jun 7, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 0d70d1d into kubernetes:master Jun 7, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jun 7, 2021
@spiffxp spiffxp deleted the bump-image-builder-cloud-sdk branch June 7, 2021 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/images cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants