Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jobs: use k8s-infra image for wg-k8s-infra jobs #22463

Merged
merged 1 commit into from
Jun 8, 2021

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Jun 7, 2021

Now that kubernetes/k8s.io#2134 has merged

The job added in #22458 has built gcr.io/k8s-staging-infra-tools/k8s-infra:latest

Use it for all wg-k8s-infra jobs

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 7, 2021
@k8s-ci-robot k8s-ci-robot requested review from BenTheElder and dims June 7, 2021 21:27
@k8s-ci-robot k8s-ci-robot added area/jobs approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. wg/k8s-infra size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 7, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Jun 7, 2021

/hold
Well actually, https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-k8sio-push-image-k8s-infra/1402003668366004224 failed with
https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-k8sio-push-image-k8s-infra/1402003668366004224#1:build-log.txt%3A13

ERROR: (gcloud.builds.submit) interpreting /home/prow/go/src/github.com/kubernetes/k8s.io/images/k8s-infra/cloudbuild.yaml as build config: .options.machineType: unused

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 7, 2021
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

command:
- bash
- make
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 7, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Jun 7, 2021

#22464 should unblock getting the image pushed

@spiffxp spiffxp force-pushed the use-k8s-infra-image branch from fa35473 to 780f52a Compare June 7, 2021 21:37
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 7, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Jun 7, 2021

pull-test-infra-yamllint wasn't happy, force-pushed to fix

config/jobs/kubernetes/wg-k8s-infra/k8sio-presubmit.yaml
  18:13     error    trailing spaces  (trailing-spaces)

@ameukam
Copy link
Member

ameukam commented Jun 7, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 7, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Jun 7, 2021

#22466 will update the image-pushing job to use an image with the latest version of gcloud, one more PR will be needed to trigger a new job to actually push the k8s-infra:latest image

@spiffxp
Copy link
Member Author

spiffxp commented Jun 7, 2021

Opened kubernetes/k8s.io#2152 to trigger a new job

@spiffxp
Copy link
Member Author

spiffxp commented Jun 8, 2021

/hold cancel
kubernetes/k8s.io#2154 finally caused an image to get pushed, so, now to verify it works with all of the jobs being updated here

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 8, 2021
@k8s-ci-robot k8s-ci-robot merged commit 6091cd5 into kubernetes:master Jun 8, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jun 8, 2021
@k8s-ci-robot
Copy link
Contributor

@spiffxp: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key k8sio-presubmit.yaml using file config/jobs/kubernetes/wg-k8s-infra/k8sio-presubmit.yaml
  • key wg-k8s-infra-trusted.yaml using file config/jobs/kubernetes/wg-k8s-infra/trusted/wg-k8s-infra-trusted.yaml

In response to this:

Now that kubernetes/k8s.io#2134 has merged

The job added in #22458 has built gcr.io/k8s-staging-infra-tools/k8s-infra:latest

Use it for all wg-k8s-infra jobs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants