Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable API availability measurement in 100 & 5k performance jobs #22276

Merged
merged 1 commit into from
May 24, 2021

Conversation

jupblb
Copy link
Contributor

@jupblb jupblb commented May 20, 2021

This PR can be merged after kubernetes/perf-tests#1809. See #21694 for further context.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 20, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @jupblb!

It looks like this is your first PR to kubernetes/test-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/test-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @jupblb. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/config Issues or PRs related to code in /config area/jobs sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels May 20, 2021
@k8s-ci-robot k8s-ci-robot requested review from marseel and wojtek-t May 20, 2021 15:52
@jupblb
Copy link
Contributor Author

jupblb commented May 20, 2021

/assign marseel
/assign tosi3k

@jupblb
Copy link
Contributor Author

jupblb commented May 20, 2021

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 20, 2021
@tosi3k
Copy link
Member

tosi3k commented May 20, 2021

Please squash the commits into a single one and make sure that the perf-tests PR is submitted beforehand.

- This reverts commit 950bff5.
- Set API availability measurement SLO
@jupblb jupblb force-pushed the api-availability branch from e2568c1 to a89db4f Compare May 20, 2021 16:33
@jupblb jupblb changed the title Api availability Reenable API availability measurement in 100 & 5k performance jobs May 21, 2021
@tosi3k
Copy link
Member

tosi3k commented May 21, 2021

/lgtm
/assign @wojtek-t
/hold - let's approve this now and merge it on Monday.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 21, 2021
@tosi3k
Copy link
Member

tosi3k commented May 21, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 21, 2021
@jupblb
Copy link
Contributor Author

jupblb commented May 24, 2021

/unhold
It's Monday ;)

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 24, 2021
@jkaniuk
Copy link
Contributor

jkaniuk commented May 24, 2021

/approve
/hold for results of preliminary tests

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 24, 2021
@jkaniuk
Copy link
Contributor

jkaniuk commented May 24, 2021

Results green
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 24, 2021
@jkaniuk
Copy link
Contributor

jkaniuk commented May 24, 2021

@wojtek-t

@wojtek-t
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkaniuk, jupblb, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2021
@k8s-ci-robot k8s-ci-robot merged commit ab7c3e8 into kubernetes:master May 24, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 24, 2021
@k8s-ci-robot
Copy link
Contributor

@jupblb: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key sig-scalability-release-blocking-jobs.yaml using file config/jobs/kubernetes/sig-scalability/sig-scalability-release-blocking-jobs.yaml

In response to this:

This PR can be merged after kubernetes/perf-tests#1809. See #21694 for further context.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jupblb jupblb deleted the api-availability branch May 24, 2021 10:22
@jupblb jupblb restored the api-availability branch July 14, 2021 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants