Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Enable API availability measurement in 100 and 5k test" #21694

Merged

Conversation

tosi3k
Copy link
Member

@tosi3k tosi3k commented Apr 7, 2021

Reverts #21498. This impacted our scalability API call latency SLO - let's revert it to mitigate it and then handle this properly in clusterloader2.

/sig scalability
/assign @wojtek-t

@k8s-ci-robot k8s-ci-robot added sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Apr 7, 2021
@k8s-ci-robot k8s-ci-robot requested review from mborsz and wojtek-t April 7, 2021 14:38
@wojtek-t
Copy link
Member

wojtek-t commented Apr 7, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 7, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tosi3k, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2021
@k8s-ci-robot k8s-ci-robot merged commit de24aaf into kubernetes:master Apr 7, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Apr 7, 2021
@k8s-ci-robot
Copy link
Contributor

@tosi3k: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key sig-scalability-release-blocking-jobs.yaml using file config/jobs/kubernetes/sig-scalability/sig-scalability-release-blocking-jobs.yaml

In response to this:

Reverts #21498. This impacted our scalability API call latency SLO - let's revert it to mitigate it and then handle this properly in clusterloader2.

/sig scalability
/assign @wojtek-t

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants