-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split prow bump #21144
Split prow bump #21144
Conversation
/assign @mpherman2 |
/lgtm |
/hold Would like to wait for @BenTheElder and @spiffxp taking a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
Keeping to oncall sounds good for now. Let's wait til after code freeze to propose formally handing off to community.
One question for followup: is there some way we could have merges of just these autobump PRs alert to slack?
Someplace to see all deploys and all config changes pushed to prow.k8s.io sounds like a good followup that would aid troubleshooting.
But being able to filter down just to "big PRs that change a lot" matches the current experience people are used to. I'd rather not take away what they're used to before having something better.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chaodaiG, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
SGTM, I do think we should relieve test-infra oncall of being concerned with these though, the community should be maintaining the images we test with in k8s.io without depending on the google infra oncall (see: recent go1.16 bump being in a bad state while people just waited for the oncall to upgrade ...) |
@chaodaiG: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixed #21137
Note that this change still results in both PRs assigned to testinfra oncalls. And #21142 was created to address this problem