Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split prow bump #21144

Merged
merged 1 commit into from
Mar 4, 2021
Merged

Split prow bump #21144

merged 1 commit into from
Mar 4, 2021

Conversation

chaodaiG
Copy link
Contributor

@chaodaiG chaodaiG commented Mar 3, 2021

Fixed #21137

Note that this change still results in both PRs assigned to testinfra oncalls. And #21142 was created to address this problem

@chaodaiG
Copy link
Contributor Author

chaodaiG commented Mar 3, 2021

/assign @mpherman2

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Mar 3, 2021
@k8s-ci-robot k8s-ci-robot requested review from dims and spiffxp March 3, 2021 22:12
@mpherman2
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 3, 2021
@chaodaiG
Copy link
Contributor Author

chaodaiG commented Mar 3, 2021

/hold

Would like to wait for @BenTheElder and @spiffxp taking a look
/cc @BenTheElder @spiffxp

@k8s-ci-robot k8s-ci-robot requested a review from BenTheElder March 3, 2021 22:19
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 3, 2021
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
Keeping to oncall sounds good for now. Let's wait til after code freeze to propose formally handing off to community.

One question for followup: is there some way we could have merges of just these autobump PRs alert to slack?

Someplace to see all deploys and all config changes pushed to prow.k8s.io sounds like a good followup that would aid troubleshooting.

But being able to filter down just to "big PRs that change a lot" matches the current experience people are used to. I'd rather not take away what they're used to before having something better.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chaodaiG, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spiffxp
Copy link
Member

spiffxp commented Mar 4, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 4, 2021
@BenTheElder
Copy link
Member

SGTM, I do think we should relieve test-infra oncall of being concerned with these though, the community should be maintaining the images we test with in k8s.io without depending on the google infra oncall (see: recent go1.16 bump being in a bad state while people just waited for the oncall to upgrade ...)

@k8s-ci-robot k8s-ci-robot merged commit c0f2cb2 into kubernetes:master Mar 4, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 4, 2021
@k8s-ci-robot
Copy link
Contributor

@chaodaiG: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key test-infra-trusted.yaml using file config/jobs/kubernetes/test-infra/test-infra-trusted.yaml

In response to this:

Fixed #21137

Note that this change still results in both PRs assigned to testinfra oncalls. And #21142 was created to address this problem

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chaodaiG chaodaiG deleted the split-bump branch March 4, 2021 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decouple test image bumping from prow bumping
5 participants