Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple test image bumping from prow bumping #21137

Closed
spiffxp opened this issue Mar 3, 2021 · 27 comments · Fixed by #21144
Closed

Decouple test image bumping from prow bumping #21137

spiffxp opened this issue Mar 3, 2021 · 27 comments · Fixed by #21144
Assignees
Labels
area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Milestone

Comments

@spiffxp
Copy link
Member

spiffxp commented Mar 3, 2021

https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/99655/pull-kubernetes-unit/1367006331575209984
=> prowjob yaml button =>
https://prow.k8s.io/prowjob?prowjob=cb9cbe1e-7bed-11eb-97bd-22fa521bf179
=> look for image: =>
gcr.io/k8s-testimages/kubekins-e2e:v20210226-c001921-master

yeah that's not going to have the go1.16, looks like we haven't had a prow bump since 02/26

we need to decouple these update loops (images for prow itself, test images) as we discussed at the last SIG testing. cc @spiffxp

Originally posted by @BenTheElder in kubernetes/kubernetes#99655 (comment)

@spiffxp
Copy link
Member Author

spiffxp commented Mar 3, 2021

/sig-testing
/area jobs
/area artifacts
/sig-release
/area release-eng
/priority important-soon
/milestone v1.21

@k8s-ci-robot k8s-ci-robot added area/jobs area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects labels Mar 3, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 3, 2021
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Mar 3, 2021
@BenTheElder
Copy link
Member

cc @chaodaiG

@chaodaiG
Copy link
Contributor

chaodaiG commented Mar 3, 2021

cc @mpherman2 as well

@chaodaiG
Copy link
Contributor

chaodaiG commented Mar 3, 2021

/assign

@spiffxp
Copy link
Member Author

spiffxp commented Mar 4, 2021

Pulling out of #21144 (review)

One question for followup: is there some way we could have merges of just these autobump PRs alert to slack?

A longer term thing: someplace to see all deploys and all config changes pushed to prow.k8s.io to aid "what changed when"

But for now being filter down just to "big PRs that change a lot" matches the current experience people are used to. I'd rather not take away what they're used to before having something better.

@spiffxp
Copy link
Member Author

spiffxp commented Mar 4, 2021

Let's figure out what it would look like to hand this off to community. My sketch:

  • if they can, community members in appropriate OWNERS can approve these now
  • wait until after code freeze, formally handoff ASAP
  • use existing groups (ci-signal or release-eng) or use this to bootstrap a prowjob-oncall
  • making sure the group knows a PR is available to merge
    • start with empty oncall field and hardcode ping to appropriate github team?
    • move to something generated by and stored in community
    • consider moving to auto-merge
  • make sure there are visible notifications when these PRs merge
    • continue practice of manually posting on slack
    • post-merge alerts sent to #prow-alerts?
    • update config-updater to send to slack?
  • document that this is how jobs configs are bumped for prow.k8s.io (a linkable subheading of https://github.com/kubernetes/test-infra/tree/master/config/jobs if there isn't a better place)

@spiffxp
Copy link
Member Author

spiffxp commented Mar 4, 2021

/reopen
the job landed, but there's still more to do

@k8s-ci-robot k8s-ci-robot reopened this Mar 4, 2021
@k8s-ci-robot
Copy link
Contributor

@spiffxp: Reopened this issue.

In response to this:

/reopen
the job landed, but there's still more to do

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chaodaiG
Copy link
Contributor

chaodaiG commented Mar 4, 2021

Also #21144 probably had left out some of the images in prow jobs that's part of prow but not gcr.io/k8s-testimages. I will take a look at the new bumping PRs generated and see what's missing

@spiffxp
Copy link
Member Author

spiffxp commented Mar 9, 2021

/sig testing

@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Mar 9, 2021
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 7, 2021
@BenTheElder
Copy link
Member

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 7, 2021
@BenTheElder
Copy link
Member

@chaodaiG this was completed right?

@chaodaiG
Copy link
Contributor

Yep it was completed

@chaodaiG
Copy link
Contributor

/close

@k8s-ci-robot
Copy link
Contributor

@chaodaiG: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BenTheElder
Copy link
Member

Thank you!

@spiffxp
Copy link
Member Author

spiffxp commented Jul 15, 2021

/reopen
Handoff never happened as described in #21137 (comment)

@k8s-ci-robot
Copy link
Contributor

@spiffxp: Reopened this issue.

In response to this:

/reopen
Handoff never happened as described in #21137 (comment)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot reopened this Jul 15, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Jul 15, 2021

FYI @kubernetes/release-engineering

@justaugustus
Copy link
Member

For SIG Release: I'm happy to have @kubernetes/release-managers in this approval group

@puerco
Copy link
Member

puerco commented Jul 17, 2021

/cc

@spiffxp
Copy link
Member Author

spiffxp commented Sep 14, 2021

/assign

@spiffxp
Copy link
Member Author

spiffxp commented Sep 14, 2021

/milestone v1.23

@spiffxp
Copy link
Member Author

spiffxp commented Sep 27, 2021

@k8s-ci-robot
Copy link
Contributor

@spiffxp: Closing this issue.

In response to this:

/close
Announcement: https://groups.google.com/g/kubernetes-dev/c/aBzQQw8KgUU/m/wnOtP5vjDAAJ

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants