-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubeadm: add jobs to test the kubelet n-1 and n-2 skew #21016
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neolit123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/sig cluster-lifecycle |
e11d64f
to
54381e7
Compare
54381e7
to
3ff159e
Compare
I think there used to be a check for kubeadm upgrade that would prevent an upgrade of the control plane with n-2 kubelets. Is that still there? Should it be disabled once these checks are enabled? |
these test jobs don't include |
Should we file a separate issue for kubeadm to update the check once this is in? |
the kubeadm kubelet skew will remain limited to N - 1 of the kubeadm version. these tests are making an exception. |
/assign @cynepco3hahue |
this is ready for review / LGTM as the k/kubeadm PR that has the test job configuration is merging: |
I do not see any problems with jobs, the single question who will be responsible to analyze failures(in the case when we will have any) |
/lgtm |
my proposal:
/hold cancel |
@neolit123 Thanks, works for me. |
/retest |
/test pull-test-infra-integration |
@neolit123: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
see discussion here:
https://groups.google.com/d/msgid/kubernetes-sig-architecture/CAH1uJ6U4qftRnmWthjYKtBKAzRFFnX7XWLMkSbyVWHUsX8%3DBBg%40mail.gmail.com?utm_medium=email&utm_source=footer
and explanation here:
kubernetes/kubeadm#2396
kubernetes/kubeadm#2396 is required before this merges.