Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubeadm: add jobs to test the kubelet n-1 and n-2 skew #21016

Merged
merged 1 commit into from
Mar 4, 2021

Conversation

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config area/jobs sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 25, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2021
@neolit123
Copy link
Member Author

/sig cluster-lifecycle
/sig node
/cc @fabriziopandini
/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Feb 25, 2021
@neolit123 neolit123 force-pushed the kubeadm-e2e branch 3 times, most recently from e11d64f to 54381e7 Compare February 25, 2021 00:27
@kfox1111
Copy link

I think there used to be a check for kubeadm upgrade that would prevent an upgrade of the control plane with n-2 kubelets. Is that still there? Should it be disabled once these checks are enabled?

@neolit123
Copy link
Member Author

I think there used to be a check for kubeadm upgrade that would prevent an upgrade of the control plane with n-2 kubelets. Is that still there? Should it be disabled once these checks are enabled?

these test jobs don't include kubeadm upgrade, as this was not discussed.
kubeadm upgrade does have a check for unsupported current kubelet version on the node which can be skipped with -f.

@kfox1111
Copy link

Should we file a separate issue for kubeadm to update the check once this is in?

@neolit123
Copy link
Member Author

Should we file a separate issue for kubeadm to update the check once this is in?

the kubeadm kubelet skew will remain limited to N - 1 of the kubeadm version. these tests are making an exception.

@SergeyKanzhelev
Copy link
Member

/assign @cynepco3hahue

@neolit123
Copy link
Member Author

this is ready for review / LGTM as the k/kubeadm PR that has the test job configuration is merging:
kubernetes/kubeadm#2396

@cynepco3hahue
Copy link

I do not see any problems with jobs, the single question who will be responsible to analyze failures(in the case when we will have any)

@cynepco3hahue
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2021
@neolit123
Copy link
Member Author

neolit123 commented Mar 4, 2021

I do not see any problems with jobs, the single question who will be responsible to analyze failures(in the case when we will have any)

my proposal:

  • if the failures are deployer related (kubeadm) - the kubeadm team will triage and fix.
  • if the kubeadm team sees potential problems in the kubelet skew we will ping sig-node, but sig-node will see the failures on their mailing list too.
  • if kubelet skew failures are not resolved by the sig-node team after a long period of time, the kubeadm team will pause / remove affected jobs. in such a case we must claim a particular skew as unsupported.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 4, 2021
@cynepco3hahue
Copy link

@neolit123 Thanks, works for me.

@neolit123
Copy link
Member Author

/retest
(job stuck on status?)

@neolit123
Copy link
Member Author

/test pull-test-infra-integration

@k8s-ci-robot k8s-ci-robot merged commit d40f387 into kubernetes:master Mar 4, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 4, 2021
@k8s-ci-robot
Copy link
Contributor

@neolit123: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key kubeadm-kinder-kubelet-x-on-y.yaml using file config/jobs/kubernetes/sig-cluster-lifecycle/kubeadm-kinder-kubelet-x-on-y.yaml

In response to this:

see discussion here:
https://groups.google.com/d/msgid/kubernetes-sig-architecture/CAH1uJ6U4qftRnmWthjYKtBKAzRFFnX7XWLMkSbyVWHUsX8%3DBBg%40mail.gmail.com?utm_medium=email&utm_source=footer

and explanation here:
kubernetes/kubeadm#2396

kubernetes/kubeadm#2396 is required before this merges.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants