kinder: add kubelet skew test jobs #2396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neolit123
added
priority/important-longterm
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
sig/cluster-lifecycle
|
/hold @fabriziopandini leaving this up for discussion for now. |
k8s-ci-robot
added
the
do-not-merge/hold
neolit123
changed the title
i proposed that we duplicate / add the jobs to a SIG Node dashboard. |
neolit123
force-pushed
the
1.21-add-kubelet-skew-jobs
branch
from
85b5d88 to
b0ac04e
Compare
|
@fabriziopandini updated. |
- add kubeletVersion as a variable - add defaultIgnorePreflightErrors with the default list of checks to skip - add ignorePreflightErrors
latest (tip of master) == n: - n control plane + kubeadm against kubelet n-1 and n-2 - n-1 control plane + kubeadm against kubelet n-2 and n-3 - n-2 control plane + kubeadm against kubelet n-3 and n-4 - n-3 control plane + kubeadm against kubelet n-4 Update kubeadm-periodic.tests.md to include details about the new jobs.
neolit123
force-pushed
the
1.21-add-kubelet-skew-jobs
branch
from
b0ac04e to
44f4ecd
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, neolit123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
let's iterate if we find problems. /hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/retest |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on the SIG Node / Arch mailing list there is a discussion around the fact that the kubelet claims support for N-2 skew against the kube-apiserver but currently there are not tests for that.
https://groups.google.com/d/msgid/kubernetes-sig-architecture/CAH1uJ6U4qftRnmWthjYKtBKAzRFFnX7XWLMkSbyVWHUsX8%3DBBg%40mail.gmail.com?utm_medium=email&utm_source=footer
on the side of kubeadm we always recommend that users match their kubelet version with the control plane version and the kubeadm version, but such skew tests can help SIG Node and feature upgrade testing in core.
these commit add tests for version skew testing with kubeadm / kinder:
NOTE: x-on-y jobs that y==x are already covered by the
regular*jobs.one caveat (as the note in kubeadm-periodic.tests.md explains) is that kubeadm doesn't really support N-2 kubelet skew (max is N-1), so in the future if changes to the kubelet happen such as these tests are no longer possible with kubeadm directly we need to re-evaluate.