Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add canary job for ci-ingress-gce-e2e #19762

Merged
merged 1 commit into from
Oct 29, 2020
Merged

Add canary job for ci-ingress-gce-e2e #19762

merged 1 commit into from
Oct 29, 2020

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented Oct 29, 2020

Duplicate of ci-ingress-gce-e2e that validates the job can run on
k8s-infra-prow-build.

Ref: kubernetes/k8s.io#1093
Part of : #18549

Signed-off-by: Arnaud Meukam [email protected]

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 29, 2020
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Oct 29, 2020
@ameukam ameukam force-pushed the canary-job-ci-ingress-gce-e2e branch 2 times, most recently from 8da7198 to 348b8b4 Compare October 29, 2020 20:28
@ameukam
Add canary job for ci-ingress-gce-e2e
ed4ea0c 
Duplicate of ci-ingress-gce-e2e that validates the job can run on
k8s-infra-prow-build.

Ref: kubernetes/k8s.io#1093
Part of : kubernetes#18549

Signed-off-by: Arnaud Meukam <[email protected]>
@ameukam ameukam force-pushed the canary-job-ci-ingress-gce-e2e branch from 348b8b4 to ed4ea0c Compare October 29, 2020 20:34
@ameukam
Copy link
Member Author

ameukam commented Oct 29, 2020

/test pull-test-infra-bazel

@ameukam
Copy link
Member Author

ameukam commented Oct 29, 2020

/assign @spiffxp

@spiffxp
Copy link
Member

spiffxp commented Oct 29, 2020

/hold
This isn't part of #18549 as the job doesn't show up on any of the release-blocking or release-informing dashboards. The ingress-related jobs for those were migrated via #18734

I'd prefer we focus on release-blocking and release-informing before moving on others

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 29, 2020
@spiffxp
Copy link
Member

spiffxp commented Oct 29, 2020

/hold cancel
/approve
/lgtm
On second thought, this is validating whether this ingress job could run via the default gce-project resource. That's useful to know; it would be great to get rid of ingress-specific projects

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Oct 29, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2020
@k8s-ci-robot k8s-ci-robot merged commit 659585d into kubernetes:master Oct 29, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Oct 29, 2020
@k8s-ci-robot
Copy link
Contributor

@ameukam: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key ingress-gce-e2e.yaml using file config/jobs/kubernetes/sig-network/ingress-gce-e2e.yaml

In response to this:

Duplicate of ci-ingress-gce-e2e that validates the job can run on
k8s-infra-prow-build.

Ref: kubernetes/k8s.io#1093
Part of : #18549

Signed-off-by: Arnaud Meukam [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ameukam
Copy link
Member Author

ameukam commented Oct 29, 2020

@spiffxp It would be great to have some updates on #18549 and #18550. It's unclear to me if some of jobs listed are considered as migrated.

@ameukam
Copy link
Member Author

ameukam commented Nov 4, 2020 •
edited
Loading

By looking at :
https://prow.k8s.io/?job=ci-ingress-gce-e2e
https://testgrid.k8s.io/sig-network-ingress-gce-e2e#ingress-gce-e2e

we can notice that the job has failed for a while. The canary fails with the same pattern: https://testgrid.k8s.io/sig-network-ingress-gce-e2e#ingress-gce-e2e.

I don't think we need to migrate this job to the community clusters.

@ameukam ameukam deleted the canary-job-ci-ingress-gce-e2e branch March 7, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowei bowei Awaiting requested review from bowei

@jingax10 jingax10 Awaiting requested review from jingax10

Assignees

@spiffxp spiffxp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.
3 participants
@ameukam @spiffxp @k8s-ci-robot