Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate release-blocking ingress jobs to k8s-infra-prow-build #18734

Merged
merged 2 commits into from
Aug 7, 2020
Merged

Migrate release-blocking ingress jobs to k8s-infra-prow-build #18734

merged 2 commits into from
Aug 7, 2020

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Aug 7, 2020 •
edited
Loading

Based on https://testgrid.k8s.io/sig-testing-canaries#gci-gce-ingress it appears these jobs do just fine with the default set of quotas available in the GCP projects in the default gce-project pool

A followup change will remove the canary job once we have sufficient history/signal from the release-blocking jobs

Part of #18651

@spiffxp
Migrate release-blocking ingress jobs to k8s-infra-prow-build
54f1ced 
Based on https://testgrid.k8s.io/sig-testing-canaries#gci-gce-ingress
it appears these jobs do just fine with the default set of quotas
available in the GCP projects in the default gce-project pool

A followup change will remove the canary job once we have sufficient
history/signal from the release-blocking jobs
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 7, 2020
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject sig/network Categorizes an issue or PR as relevant to SIG Network. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Aug 7, 2020
@spiffxp spiffxp mentioned this pull request Aug 7, 2020
Closed
@spiffxp
Raise static resource limits in jobs test
eaa75cf 
I am halfway inclined to remove this as it's a poor approximation of
resource usage, and I'm not sure what corrective action would be taken
by someone other than just raising it (as I'm doing now). It's still
the closest thing to a canary about resource usage not going way above
what we would expect
@spiffxp
Copy link
Member Author

spiffxp commented Aug 7, 2020

/cc @BenTheElder @hasheddan
FYI @kubernetes/ci-signal

hasheddan
hasheddan approved these changes Aug 7, 2020
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 7, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasheddan, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 013860b into kubernetes:master Aug 7, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Aug 7, 2020
@k8s-ci-robot
Copy link
Contributor

@spiffxp: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key generated.yaml using file config/jobs/kubernetes/generated/generated.yaml
  • key sig-network-misc.yaml using file config/jobs/kubernetes/sig-network/sig-network-misc.yaml

In response to this:

Based on https://testgrid.k8s.io/sig-testing-canaries#gci-gce-ingress it appears these jobs do just fine with the default set of quotas available in the GCP projects in the default gce-project pool

A followup change will remove the canary job once we have sufficient history/signal from the release-blocking jobs

Part of #18651

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp spiffxp deleted the mv-ingress-release-blocking-to-k8s-infra branch August 7, 2020 21:13
@spiffxp spiffxp mentioned this pull request Aug 8, 2020
Closed
18 tasks
@spiffxp spiffxp mentioned this pull request Oct 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasheddan hasheddan hasheddan approved these changes

@justaugustus justaugustus Awaiting requested review from justaugustus

@saschagrunert saschagrunert Awaiting requested review from saschagrunert

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

Assignees

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
3 participants
@spiffxp @k8s-ci-robot @hasheddan