Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kind job updates #19168

Merged
merged 2 commits into from
Sep 9, 2020
Merged

kind job updates #19168

merged 2 commits into from
Sep 9, 2020

Conversation

BenTheElder
Copy link
Member

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 9, 2020
@BenTheElder BenTheElder mentioned this pull request Sep 9, 2020
Merged
hasheddan
hasheddan approved these changes Sep 9, 2020
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

BenTheElder
BenTheElder commented Sep 9, 2020
View reviewed changes
config/jobs/kubernetes-sigs/kind/kind-presubmits.yaml
@@ -403,7 +403,7 @@ presubmits:
- name: "PARALLEL"
value: "true"
- name: BUILD_TYPE
value: bazel
value: not-bazel
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/kubernetes-sigs/kind/blob/c58694155106d0ac6e9612b7af5d0ac4f0559ba3/hack/ci/e2e-k8s.sh#L266-L275

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 9, 2020
@justaugustus
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, hasheddan, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justaugustus justaugustus mentioned this pull request Sep 9, 2020
Closed
@k8s-ci-robot k8s-ci-robot merged commit 266371b into kubernetes:master Sep 9, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Sep 9, 2020
@k8s-ci-robot
Copy link
Contributor

@BenTheElder: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key kind-presubmits.yaml using file config/jobs/kubernetes-sigs/kind/kind-presubmits.yaml

In response to this:

unblock kubernetes-sigs/kind#1841

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BenTheElder BenTheElder deleted the kind-jobs branch March 4, 2021 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasheddan hasheddan hasheddan approved these changes

@munnerz munnerz Awaiting requested review from munnerz

@neolit123 neolit123 Awaiting requested review from neolit123

Assignees

@justaugustus justaugustus

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.
4 participants
@BenTheElder @justaugustus @k8s-ci-robot @hasheddan