bazel: derive exec path of go binaries from action graph

[mikedanese]

Output paths are not a stable API and all our conditional path
construction here is fragile. This replaces the old path construction
with queries to the action graph.

Part of unblocking: kubernetes/kubernetes#94449

cc @justaugustus @BenTheElder

[BenTheElder]

Output paths are not a stable API

That's a bit ridiculous. The bazel output directories are documented. In any sane build system I would expect to be able to obtain built binaries without having to construct some query and parse the output :/

This is another one for kubernetes/kubernetes#88553 @dims @thockin @justaugustus

and all our conditional path construction here is fragile.

I also take issue with this. We're only conditionally checking against one breakage ever when upstream introduced limited cross compilation in 1.14+, which changed the binary names. There's nothing fragile about the existing logic, bazel's output is fragile.

[BenTheElder]

/lgtm
/approve

I appreciate filing a fix for kubernetes/kubernetes#94449, but I think this highlights why we have near zero adoption of this build outside of CI.

A consumer should be able to predict something like bazel-bin/cmd/kubelet without needing to construct a command and parse json etc.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, mikedanese

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [BenTheElder]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[BenTheElder]

/retest

[mikedanese]

That's a bit ridiculous.

Agree, this one had me scratching my head...

[justaugustus]

I agree that bazel makes me feel ridiculous on a regular basis.
Opened kubernetes/test-infra#19166 to add 1.19 kind tests and drop the tests for 1.16 and 1.15 branches (which are now EOL).

[justaugustus]

@BenTheElder -- you may want/need to override the pull-kind-conformance-parallel-1-15 job if it continues to fail.

[k8s-ci-robot]

New changes are detected. LGTM label has been removed.

[mikedanese]

1.15 is still on bazel 0.23 it looks like and aquery didn't support json output. I modified this to use proto instead of json since it seemed the easiest but if you don't like this, we could all:

1. munge the info out of textproto
2. less ideally, stop supporting 1.15... what's the support policy for kind?

[justaugustus]

I agree that bazel makes me feel ridiculous on a regular basis.
Opened kubernetes/test-infra#19166 to add 1.19 kind tests and drop the tests for 1.16 and 1.15 branches (which are now EOL).

@mikedanese -- Already opened a PR to drop those tests.

[justaugustus]

what's the support policy for kind?

Probably(/hopefully) the same as Kubernetes, so dev (1.20), 1.19, 1.18, and 1.17.

[mikedanese]

Ok, then I'll drop the last commit and we can skip 1.15.

[BenTheElder]

KIND currently supports 1.13+ (kubeadm beta versions) but we only need bazel in Kubernetes CI.
EDIT: and versions that are not in CI are best-effort.

I'm fine with dropping bazel-only support from anything Kubernetes isn't running CI for.

[BenTheElder]

kubernetes/test-infra#19168 disables bazel in that job.
I'm OK bypassing broken CI to merge this though.

[BenTheElder]

we're also hitting pod pending timeouts on prow w/ running the jobs :/
/test pull-kind-conformance-parallel-1-16
/test pull-kind-e2e-kubernetes
(prow pending timeout)

[mikedanese]

For posterity since GH UI lost it, the dropped commit that made this work for 1.15 is here: 29491d7

[k8s-ci-robot]

@mikedanese: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-kind-conformance-parallel-1-15	e0ff673	link	/test pull-kind-conformance-parallel-1-15
pull-kind-conformance-parallel-1-17	e0ff673	link	/test pull-kind-conformance-parallel-1-17

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[BenTheElder]

bypassing e2e flakes and ensuring this one goes in now.