Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure pull-release-verify securityContext is on container #13261

Merged
merged 1 commit into from
Jun 28, 2019
Merged

Ensure pull-release-verify securityContext is on container #13261

merged 1 commit into from
Jun 28, 2019

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Jun 28, 2019

ref: #13258
ref: #13125

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 28, 2019
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 28, 2019
spiffxp
spiffxp commented Jun 28, 2019
View reviewed changes
config/jobs/kubernetes/release/release-config.yaml Outdated
securityContext:
privileged: true
securityContext:
privileged: true
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevekuznetsov @cjwagner could we have caught this via a presubmit?

@spiffxp
Copy link
Member Author

spiffxp commented Jun 28, 2019

🔥 YAML 🔥

@spiffxp spiffxp force-pushed the fix-pull-release-verify-sc branch from 73d68dd to e8b41db Compare June 28, 2019 18:03
@spiffxp
Copy link
Member Author

spiffxp commented Jun 28, 2019

FYI @pswica

@spiffxp
Copy link
Member Author

spiffxp commented Jun 28, 2019

Should address kubernetes/release#757

@pswica
Copy link
Contributor

pswica commented Jun 28, 2019

🔥 YAML 🔥

Hahaha. I was actually on vim trying to trace my lines doing this too...

fejta
fejta approved these changes Jun 28, 2019
View reviewed changes
Copy link
Contributor

@fejta fejta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙃

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 28, 2019
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c547e3afd207a67a283eb4d43e89a7bd508693d1

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c40317a into kubernetes:master Jun 28, 2019
@k8s-ci-robot
Copy link
Contributor

@spiffxp: Updated the job-config configmap in namespace default using the following files:

  • key release-config.yaml using file config/jobs/kubernetes/release/release-config.yaml

In response to this:

ref: #13258
ref: #13125

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp spiffxp deleted the fix-pull-release-verify-sc branch June 28, 2019 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fejta fejta fejta approved these changes

@justaugustus justaugustus Awaiting requested review from justaugustus

Assignees

@fejta fejta

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spiffxp @pswica @k8s-ci-robot @fejta