adding optional presubmit verify-shellcheck.sh job

[pswica]

/sig release
/cc @justaugustus

Continues this PR: kubernetes/release#740

Which addresses this issue: kubernetes/release#726

Specifically, this will run a job that links the shell scripts in kubernetes/release. I will use this test to clean up the shell scripts, and then make it an always-run job

[k8s-ci-robot]

Hi @pswica. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[justaugustus]

Made some suggestions.
Would much prefer a Makefile, with a verify target which runs a set of verify scripts instead.
See here for an example.

This allows us to change the underlying implementation in k/release without having to also issue an update to the test-infra job definition.

[pswica]

@justaugustus thanks a lot for guiding me through this. Your suggestions definitely improve this test. I will try to implement this

[justaugustus]

Sorry, one more change (because I was spacing out on the job name).

[justaugustus]

/ok-to-test
/lgtm
/approve

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: c839393a12237e917098de336086046abede28b5

[pswica]

/retest

[fejta-bot]

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

[justaugustus]

@pswica -- Add this block under

test-infra/testgrid/config.yaml

Lines 3107 to 3110 in 5839ecd

	- name: release-unit
	test_group_name: pull-release-unit
	alert_options:
	alert_mail_to_addresses: [email protected]

  - name: release-verify
    test_group_name: pull-release-verify
    alert_options:
      alert_mail_to_addresses: [email protected]

[pswica]

@justaugustus
Thank you--I added. Thanks for being patient with me as I learn about test-infra jobs

[justaugustus]

For sure, anytime @pswica!
/lgtm
/approve

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: be4590276fbb554b8243a56f4cbb4244afa4373a

[justaugustus]

/assign @spiffxp

[spiffxp]

/hold
depends on kubernetes/release#740

[justaugustus]

Removing the hold on this as kubernetes/release#740 has been merged! 🎉
@spiffxp -- please approve when you have a chance.

/hold cancel

[BenTheElder]

this needs docker in docker enabled, the kubekins image does not have shellcheck (and it probably shouldn't)

to do that:

• put runner.sh as the first entry in command (this will boot docker)
• add this to the prowjob spec:

  labels:
      preset-dind-enabled: "true"

• add this to the pod spec:

securityContext:
          privileged: true

[pswica]

@BenTheElder
Thanks a lot for your help. I saw your really cool shellcheck update, and I'm really glad to have another experienced set of eyes looking at my stuff. I really appreciate it :)

[spiffxp]

/approve
/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: abade9b194cbb47e388305f7dbac0bcd19b6cfeb

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, pswica, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• config/jobs/kubernetes/release/OWNERS [justaugustus,spiffxp]
• testgrid/OWNERS [spiffxp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

@pswica: Updated the job-config configmap in namespace default using the following files:

• key release-config.yaml using file config/jobs/kubernetes/release/release-config.yaml

In response to this:

/sig release
/cc @justaugustus

Continues this PR: kubernetes/release#740

Which addresses this issue: kubernetes/release#726

Specifically, this will run a job that links the shell scripts in kubernetes/release. I will use this test to clean up the shell scripts, and then make it an always-run job

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.