Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kinder X on Y tests #12467

Merged

Conversation

fabriziopandini
Copy link
Member

This PR adds kinder X on Y tests; those jobs, once stabilized and evaluated reliable, are going to replace the failing kubeadm-gce-X-on-Y jobs based on kubernetes-anywhere (which is not maintained anymore)

This PR will remain WIP until kubernetes/kubeadm#1553 will merge

Rif. kubernetes/kubeadm#1543

/sig cluster-lifecycle
/kind feature
/priority important-longterm
/assign @neolit123

@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/testgrid sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels May 3, 2019
@k8s-ci-robot k8s-ci-robot requested review from justinsb and luxas May 3, 2019 16:14
extra_refs:
- org: kubernetes
repo: kubernetes
base_ref: release-1.14
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this means we are building both e2e and kubeadm-e2e from release-1.14, given we are testing the kubeadm binary from master, shouldn't we be testing this binary against kubeadm-e2e from master?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kubeadm master should be able to bootstrap a Kubernetes cluster v1.14
Then we are going to use E2E test suite v1.14 and E2E kubeadm test suite v1.14 to check that the Kubernetes cluster (v1.14 too) works properly

In other words, test should be of the same version of cluster I am testing, not of version the bootstrap tool

Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/assign @michelle192837
hi, we are adding more jobs to testgrid for kubeadm. PTAL.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2019
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 70fbda7aa37ef2a8fd34917d80e98a3166540a31

@michelle192837
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, michelle192837

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2019
@k8s-ci-robot k8s-ci-robot merged commit 1423204 into kubernetes:master May 3, 2019
@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: Updated the job-config configmap in namespace default using the following files:

  • key kubeadm-kinder-x-on-y.yaml using file config/jobs/kubernetes/sig-cluster-lifecycle/kubeadm-kinder-x-on-y.yaml

In response to this:

This PR adds kinder X on Y tests; those jobs, once stabilized and evaluated reliable, are going to replace the failing kubeadm-gce-X-on-Y jobs based on kubernetes-anywhere (which is not maintained anymore)

This PR will remain WIP until kubernetes/kubeadm#1553 will merge

Rif. kubernetes/kubeadm#1543

/sig cluster-lifecycle
/kind feature
/priority important-longterm
/assign @neolit123

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fabriziopandini fabriziopandini deleted the kinder-x-on-y-tests branch May 5, 2019 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants