-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kinder X on Y tests #12467
Add kinder X on Y tests #12467
Conversation
extra_refs: | ||
- org: kubernetes | ||
repo: kubernetes | ||
base_ref: release-1.14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so this means we are building both e2e and kubeadm-e2e from release-1.14, given we are testing the kubeadm binary from master, shouldn't we be testing this binary against kubeadm-e2e from master?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kubeadm master should be able to bootstrap a Kubernetes cluster v1.14
Then we are going to use E2E test suite v1.14 and E2E kubeadm test suite v1.14 to check that the Kubernetes cluster (v1.14 too) works properly
In other words, test should be of the same version of cluster I am testing, not of version the bootstrap tool
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign @michelle192837
hi, we are adding more jobs to testgrid for kubeadm. PTAL.
LGTM label has been added. Git tree hash: 70fbda7aa37ef2a8fd34917d80e98a3166540a31
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini, michelle192837 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@fabriziopandini: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR adds kinder X on Y tests; those jobs, once stabilized and evaluated reliable, are going to replace the failing kubeadm-gce-X-on-Y jobs based on kubernetes-anywhere (which is not maintained anymore)
This PR will remain WIP until kubernetes/kubeadm#1553 will merge
Rif. kubernetes/kubeadm#1543
/sig cluster-lifecycle
/kind feature
/priority important-longterm
/assign @neolit123