Kinder: add X on Y tests #1553
Merged
Kinder: add X on Y tests #1553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
sig/cluster-lifecycle
neolit123
reviewed
May 3, 2019
| timeout: 5m | ||
| # kind export log is know to be flaky, so we are temporary ignoring errors in order | ||
| # to make the test pass in case everything else passed | ||
| # see https://github.com/kubernetes-sigs/kind/issues/456 |
There was a problem hiding this comment.
i need to test this again, upstream merged a patch.
fabriziopandini
force-pushed
the
x-on-y-tests
branch
from
1b1351e to
5402126
Compare
|
@neolit123 everything should be addressed now. |
|
thanks |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini, neolit123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds kinder X on Y tests (the kinder part of those test)
NB. the PR includes some small nits on other jobs
/assign @neolit123
/cc @kubernetes/sig-cluster-lifecycle-pr-reviews