Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kops: move gofmt job to use bazel image #12298

Merged

Conversation

justinsb
Copy link
Member

So that we can source the correct version of go & gofmt, it makes
sense to use the gofmt from the bazel @go_sdk, as done in
k8s.io/repo-infra.

This requires that we use the bazel image.

Related PR kubernetes/kops#6798

@k8s-ci-robot
Copy link
Contributor

Keywords which can automatically close issues and at(@) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

  • 3d728a2 kops: move gofmt job to use bazel image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 21, 2019
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 21, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Apr 21, 2019
So that we can source the correct version of go & gofmt, it makes
sense to use the gofmt from the bazel go_sdk, as done in
k8s.io/repo-infra.

This requires that we use the bazel image.

Related PR kubernetes/kops#6798
@justinsb justinsb force-pushed the move_kops_gofmt_test_to_bazel branch from 3d728a2 to 4fcacab Compare April 22, 2019 16:04
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Apr 22, 2019
@spiffxp
Copy link
Member

spiffxp commented Apr 22, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 22, 2019
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8b57367304a5bf325a20137feb870f5e6d66a8c6

@k8s-ci-robot k8s-ci-robot merged commit b7180c5 into kubernetes:master Apr 22, 2019
@k8s-ci-robot
Copy link
Contributor

@justinsb: Updated the job-config configmap in namespace default using the following files:

  • key kops-config.yaml using file config/jobs/kubernetes/kops/kops-config.yaml

In response to this:

So that we can source the correct version of go & gofmt, it makes
sense to use the gofmt from the bazel @go_sdk, as done in
k8s.io/repo-infra.

This requires that we use the bazel image.

Related PR kubernetes/kops#6798

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants