-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kops: move gofmt job to use bazel image #12298
kops: move gofmt job to use bazel image #12298
Conversation
Keywords which can automatically close issues and at(@) mentions are not allowed in commit messages. The list of commits with invalid commit messages:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
So that we can source the correct version of go & gofmt, it makes sense to use the gofmt from the bazel go_sdk, as done in k8s.io/repo-infra. This requires that we use the bazel image. Related PR kubernetes/kops#6798
3d728a2
to
4fcacab
Compare
/lgtm |
LGTM label has been added. Git tree hash: 8b57367304a5bf325a20137feb870f5e6d66a8c6
|
@justinsb: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
So that we can source the correct version of go & gofmt, it makes
sense to use the gofmt from the bazel @go_sdk, as done in
k8s.io/repo-infra.
This requires that we use the bazel image.
Related PR kubernetes/kops#6798