Skip to content

Commit

Permalink
kops: move gofmt job to use bazel image
Browse files Browse the repository at this point in the history
So that we can source the correct version of go & gofmt, it makes
sense to use the gofmt from the bazel @go_sdk, as done in
k8s.io/repo-infra.

This requires that we use the bazel image.

Related PR kubernetes/kops#6798
  • Loading branch information
justinsb committed Apr 21, 2019
1 parent 143a95a commit 3d728a2
Showing 1 changed file with 10 additions and 4 deletions.
14 changes: 10 additions & 4 deletions config/jobs/kubernetes/kops/kops-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -129,16 +129,22 @@ presubmits:
always_run: true
labels:
preset-service-account: "true"
preset-bazel-scratch-dir: "true"
preset-bazel-remote-cache-enabled: "true"
spec:
containers:
- image: gcr.io/k8s-testimages/gcloud-in-go:v20180927-6b4facbe6
- image: gcr.io/k8s-testimages/kubekins-e2e:v20190329-811f7954b-experimental
args:
- "--job=$(JOB_NAME)"
- "--repo=k8s.io/$(REPO_NAME)=$(PULL_REFS)"
- "--root=/go/src"
- "--service-account=/etc/service-account/service-account.json"
- "--upload=gs://kubernetes-jenkins/pr-logs"
- --scenario=execute
- --
- "--scenario=kubernetes_execute_bazel"
- "--" # end bootstrap args, scenario args below
- ./hack/verify-gofmt.sh
resources:
requests:
memory: "2Gi"

- name: pull-kops-verify-govet
branches:
Expand Down

0 comments on commit 3d728a2

Please sign in to comment.