Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update capz presubmits to use latest-1.14 image #12217

Merged
merged 1 commit into from
Apr 16, 2019
Merged

Update capz presubmits to use latest-1.14 image #12217

merged 1 commit into from
Apr 16, 2019

Conversation

justaugustus
Copy link
Member

Signed-off-by: Stephen Augustus [email protected]

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 16, 2019
@justaugustus
Copy link
Member Author

/assign @soggiest @feiskyer @andyzhangx

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 16, 2019
andyzhangx
andyzhangx approved these changes Apr 16, 2019
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: dba5f93c86f13a887ccd66889c504d6e6de8e18a

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 16, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ba03090 into kubernetes:master Apr 16, 2019
@k8s-ci-robot
Copy link
Contributor

@justaugustus: Updated the job-config configmap in namespace default using the following files:

  • key cluster-api-provider-azure-presubmits.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-azure/cluster-api-provider-azure-presubmits.yaml

In response to this:

Signed-off-by: Stephen Augustus [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

feiskyer
feiskyer reviewed Apr 16, 2019
View reviewed changes
...g/jobs/kubernetes-sigs/cluster-api-provider-azure/cluster-api-provider-azure-presubmits.yaml
@@ -17,7 +18,8 @@ presubmits:
path_alias: "sigs.k8s.io/cluster-api-provider-azure"
spec:
containers:
- image: gcr.io/k8s-testimages/kubekins-e2e:v20190329-811f7954b-1.12
- image: gcr.io/k8s-testimages/kubekins-e2e:latest-1.14
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we use images built from master, e.g. gcr.io/k8s-testimages/kubekins-e2e:v20190329-811f7954b-master? Most packages are using this image instead of latest-1.14 tag.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@feiskyer -- I bumped to latest-master in #12224

@Katharine
Copy link
Member

Just curious: why latest?

This was referenced Apr 16, 2019
Merged
Merged
Merged
@justaugustus
Copy link
Member Author

@Katharine -- I like to live dangerously :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@andyzhangx andyzhangx andyzhangx approved these changes

@karataliu karataliu Awaiting requested review from karataliu

@khenidak khenidak Awaiting requested review from khenidak

Assignees

@feiskyer feiskyer

@andyzhangx andyzhangx

@soggiest soggiest

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@justaugustus @k8s-ci-robot @Katharine @feiskyer @andyzhangx @soggiest