Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mock interfaces #182

Merged
merged 1 commit into from
Apr 16, 2019
Merged

Add mock interfaces #182

merged 1 commit into from
Apr 16, 2019

Conversation

justaugustus
Copy link
Member

@justaugustus justaugustus commented Apr 13, 2019 •
edited
Loading

Signed-off-by: Stephen Augustus [email protected]

What this PR does / why we need it:
This is a first pass at adding mocks to the project.
I've deleted the old (pre-refactor) mock interfaces and leveraged the gomock and the bazel generation rules to create new mocks.

With new mocks, we can start to deepen our test coverage across the Azure resource-level packages.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
This is needed to enable some testing work on #174.

Release note:

Add mock interfaces

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. area/provider/azure Issues or PRs related to azure provider labels Apr 13, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 13, 2019
@justaugustus justaugustus force-pushed the mocks branch 2 times, most recently from 44ab32b to 544f35d Compare April 14, 2019 05:10
@justaugustus justaugustus changed the title [WIP] Add mock interfaces Add mock interfaces Apr 14, 2019
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 14, 2019
@justaugustus
Copy link
Member Author

/assign @awesomenix @soggiest
/priority important-soon
/milestone v1alpha1
/area testing

@k8s-ci-robot k8s-ci-robot added this to the v1alpha1 milestone Apr 14, 2019
@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Apr 14, 2019
@justaugustus justaugustus mentioned this pull request Apr 14, 2019
Closed
@justaugustus justaugustus changed the title Add mock interfaces [WIP] Add mock interfaces Apr 16, 2019
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 16, 2019
@justaugustus
Copy link
Member Author

(Pivoting a little on the mocks to utilize bazel_gomock, so I'm setting this as WIP again.)

@justaugustus
Copy link
Member Author

/test pull-cluster-api-provider-azure-bazel-test

@justaugustus
Add mock interfaces
8a48fff 
Signed-off-by: Stephen Augustus <[email protected]>
@justaugustus justaugustus changed the title [WIP] Add mock interfaces Add mock interfaces Apr 16, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 16, 2019
@justaugustus
Copy link
Member Author

Cross-linking kubernetes-sigs/cluster-api-provider-aws#719 since our mock tests are now failing like @vincepri's tests

@justaugustus
Copy link
Member Author

/retest

@justaugustus
Copy link
Member Author

/test pull-cluster-api-provider-azure-bazel-test

@justaugustus
Copy link
Member Author

(Re-running tests for paranoia's sake)
/retest

@justaugustus justaugustus mentioned this pull request Apr 16, 2019
Merged
@justaugustus
Copy link
Member Author

Builds were failing due to the images we are using for this repo's presubmits. After merging kubernetes/test-infra#12217, all is well!

soggiest
soggiest approved these changes Apr 16, 2019
View reviewed changes
Copy link
Contributor

@soggiest soggiest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 16, 2019
@k8s-ci-robot k8s-ci-robot merged commit 08ac1b3 into kubernetes-sigs:master Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awesomenix awesomenix awesomenix requested changes

@soggiest soggiest soggiest approved these changes

@serbrech serbrech Awaiting requested review from serbrech

Assignees

@awesomenix awesomenix

@soggiest soggiest

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v0.2
Development

Successfully merging this pull request may close these issues.
4 participants
@justaugustus @k8s-ci-robot @awesomenix @soggiest