Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST] remove kubeadm-gce* tests from release blocking #518

Closed
neolit123 opened this issue Feb 24, 2019 · 12 comments · Fixed by kubernetes/test-infra#12493
Closed

[REQUEST] remove kubeadm-gce* tests from release blocking #518

neolit123 opened this issue Feb 24, 2019 · 12 comments · Fixed by kubernetes/test-infra#12493
Assignees
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject area/release-team Issues or PRs related to the release-team subproject kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Milestone

Comments

@neolit123
Copy link
Member

neolit123 commented Feb 24, 2019

summary:

the family of tests kubadm-gce*:
https://k8s-testgrid.appspot.com/sig-cluster-lifecycle-all

are a based on a deprecated and unmaintained project called kubernetes-anywhere:
https://github.com/kubernetes/kubernetes-anywhere/

to be able to test such deployments we are using a deployer in test-infra called kubernetes-anywhere
https://github.com/kubernetes/test-infra/blob/master/kubetest/anywhere.go

request:

remove the following tests from release-blocking dashboards:

  • kubeadm-gce-master (or a release branch)
  • kubeadm-gce-x-on-y (where x and y are k releases)

replace with:

  • kubeadm-kind-* (master is done, 1.xx branch tests are to be fixed early next week, hopefully)
  • periodic-packages-install-deb

rationale:

we don't have a replacement for kubeadm-gce-x-on-y yet but it will come in the 1.15 cycle.

stakeholders:

i'm going to add some developers here that have witnessed the horrors of kubernetes-anywhere lately:
@fabriziopandini @krzyzacy @BenTheElder @neolit123

/sig release
/sig cluster-lifecycle
/sig testing


/assign @timothysc @spiffxp @neolit123

@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 24, 2019
@neolit123
Copy link
Member Author

/kind cleanup

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Feb 24, 2019
@timothysc
Copy link
Member

Yes please, KILL IT WITH FIRE!!!

@krzyzacy
Copy link
Member

/pony agree

@k8s-ci-robot
Copy link
Contributor

@krzyzacy: Couldn't find a pony matching that query.

In response to this:

/pony agree

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp
Copy link
Member

spiffxp commented Feb 25, 2019

/milestone v1.14

@k8s-ci-robot k8s-ci-robot added this to the v1.14 milestone Feb 25, 2019
@spiffxp
Copy link
Member

spiffxp commented Feb 25, 2019

Discussed briefly in today's release-team meeting and sigs.k8s.io/kind meeting. Summarizing discussion with @BenTheElder @dims @neolit123

I'm not interested in just immediately flipping things around and using that as precedent. But I agree with the rationale. I lean in favor of this given that it's the sole job that provides kubeadm coverage, and this ask is generally agreed up by the maintainers of all relevant projects.

There was concern that this will drop coverage of "kubeadm + gcp cloud provider" from release-blocking, but we feel that kind will provide sufficient "kubeadm" coverage, and the existing kube-up jobs provide sufficient "gcp cloud provider" coverage.

My proposal:

  • move release-master-blocking/kubeadm-gce-master to release-master-informing
  • move release-master-blocking/kubeadm-gce-stable-on-master to release-master-informing
  • for release-1.y-blocking variants, move to release-1.y-all (if they aren't already there)
  • add kind jobs to release-master-informing
  • wait for a week to collect data
  • if we find signal looks good, move kind jobs to release-master-blocking

@spiffxp
Copy link
Member

spiffxp commented Feb 25, 2019

/assign @amwat @mariantalla
test-infra and ci-signal changes for 1.14

@spiffxp
Copy link
Member

spiffxp commented Feb 25, 2019

@neolit123 one outstanding question I have is:

@neolit123
Copy link
Member Author

neolit123 commented Feb 25, 2019

@spiffxp

  • move release-master-blocking/kubeadm-gce-master to release-master-informing
  • move release-master-blocking/kubeadm-gce-stable-on-master to release-master-informing
  • for release-1.y-blocking variants, move to release-1.y-all (if they aren't already there)
  • add kind jobs to release-master-informing
  • wait for a week to collect data
  • if we find signal looks good, move kind jobs to release-master-blocking

thank you. i will start sending the PRs for this change.

  • is this what you mean by periodic-packages-install-deb? are there release-branch variants that need to exist?

these two jobs:
https://testgrid.k8s.io/sig-cluster-lifecycle-all#periodic-packages-pushed
https://testgrid.k8s.io/sig-cluster-lifecycle-all#periodic-packages-install-deb
test the whole currently support version skew.

periodic-packages-install-deb also tests the installation of latest CI artifacts.

so we technically don't need release branch variants for these. possibly keeping them in release master blocking is sufficient. except that instead of blocking we might want to move them to release-informing because they can block master due to say the 1.12.10 packages missing.

@justaugustus
Copy link
Member

justaugustus commented May 1, 2019

Do we have someone driving this forward for 1.15?
/milestone v1.15
/area release-team release-eng
/priority critical-urgent

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.14, v1.15 May 1, 2019
@k8s-ci-robot k8s-ci-robot added area/release-team Issues or PRs related to the release-team subproject area/release-eng Issues or PRs related to the Release Engineering subproject labels May 1, 2019
@k8s-ci-robot k8s-ci-robot added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label May 1, 2019
@neolit123
Copy link
Member Author

@justaugustus
yes.
the problem jobs are already out of release blocking, but feel free to keep this around as the replacements are not in place yet.

@imkin
Copy link

imkin commented May 6, 2019

/cc imkin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject area/release-team Issues or PRs related to the release-team subproject kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants