-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REQUEST] remove kubeadm-gce* tests from release blocking #518
Comments
/kind cleanup |
Yes please, KILL IT WITH FIRE!!! |
/pony agree |
@krzyzacy: Couldn't find a pony matching that query. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/milestone v1.14 |
Discussed briefly in today's release-team meeting and sigs.k8s.io/kind meeting. Summarizing discussion with @BenTheElder @dims @neolit123 I'm not interested in just immediately flipping things around and using that as precedent. But I agree with the rationale. I lean in favor of this given that it's the sole job that provides kubeadm coverage, and this ask is generally agreed up by the maintainers of all relevant projects. There was concern that this will drop coverage of "kubeadm + gcp cloud provider" from release-blocking, but we feel that kind will provide sufficient "kubeadm" coverage, and the existing kube-up jobs provide sufficient "gcp cloud provider" coverage. My proposal:
|
/assign @amwat @mariantalla |
@neolit123 one outstanding question I have is:
|
thank you. i will start sending the PRs for this change.
these two jobs:
so we technically don't need release branch variants for these. possibly keeping them in release master blocking is sufficient. except that instead of blocking we might want to move them to release-informing because they can block master due to say the 1.12.10 packages missing. |
Do we have someone driving this forward for 1.15? |
@justaugustus |
/cc imkin |
summary:
the family of tests kubadm-gce*:
https://k8s-testgrid.appspot.com/sig-cluster-lifecycle-all
are a based on a deprecated and unmaintained project called kubernetes-anywhere:
https://github.com/kubernetes/kubernetes-anywhere/
to be able to test such deployments we are using a deployer in test-infra called
kubernetes-anywhere
https://github.com/kubernetes/test-infra/blob/master/kubetest/anywhere.go
request:
remove the following tests from release-blocking dashboards:
replace with:
rationale:
https://k8s-testgrid.appspot.com/sig-cluster-lifecycle-all#kubeadm-kind-master
https://k8s-testgrid.appspot.com/sig-cluster-lifecycle-all#periodic-packages-install-deb
this means we cannot debug properly the test jobs. there might be a solution for that, but after a number of PRs i gave up.
we don't have a replacement for
kubeadm-gce-x-on-y
yet but it will come in the 1.15 cycle.stakeholders:
i'm going to add some developers here that have witnessed the horrors of kubernetes-anywhere lately:
@fabriziopandini @krzyzacy @BenTheElder @neolit123
/sig release
/sig cluster-lifecycle
/sig testing
/assign @timothysc @spiffxp @neolit123
The text was updated successfully, but these errors were encountered: